Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NodeJS usage examples for Helm, YAML, and Kustomize #1205

Merged
merged 1 commit into from
Jul 9, 2020

Conversation

lblackstone
Copy link
Member

Proposed changes

Related issues (optional)

Related to #1204

@lblackstone lblackstone requested a review from metral July 8, 2020 22:44
Copy link
Contributor

@metral metral left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! 🎉 Overall LGTM - one meta question: do we have any way to test & validate these examples to make sure they stay up-to-date?

I'm not sure if our docs overlays supports this

@@ -121,6 +205,49 @@ export class ConfigGroup extends CollectionComponentResource {
/**
* ConfigFile creates a set of Kubernetes resources from Kubernetes YAML file. If `config.name`
* is not specified, `ConfigFile` assumes the argument `name` is the filename.
*
* ## Example Usage
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this block below looks like a dupe of the block above it. are they supposed to be similar?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, ConfigGroup and ConfigFile have similar usages

@lblackstone
Copy link
Member Author

do we have any way to test & validate these examples to make sure they stay up-to-date?

This is a great idea, but I don't think we have any way of doing this automatically right now. I tested these as I wrote them.

@lblackstone lblackstone merged commit 2bf17bb into master Jul 9, 2020
@pulumi-bot pulumi-bot deleted the lblackstone/nodejs-overlay-examples branch July 9, 2020 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants