Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add C# usage examples for Helm, YAML, and Kustomize #1213

Merged
merged 3 commits into from
Jul 23, 2020

Conversation

lblackstone
Copy link
Member

@lblackstone lblackstone commented Jul 22, 2020

Proposed changes

Related issues (optional)

#1204

@lblackstone lblackstone force-pushed the lblackstone/dotnet-overlay-docs branch from e37c19e to c091287 Compare July 22, 2020 20:10
@lblackstone lblackstone marked this pull request as ready for review July 22, 2020 20:10
Copy link
Member

@mikhailshilkov mikhailshilkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great - I only had a few minor suggestions.

Meta question - aren't we able to generate these from Pulumi Programs yet? Is there a plan to get there?

provider/pkg/gen/dotnet-templates/helm/v2/Chart.cs Outdated Show resolved Hide resolved
provider/pkg/gen/dotnet-templates/helm/v2/Chart.cs Outdated Show resolved Hide resolved
provider/pkg/gen/dotnet-templates/helm/v2/Chart.cs Outdated Show resolved Hide resolved
@lblackstone
Copy link
Member Author

Meta question - aren't we able to generate these from Pulumi Programs yet? Is there a plan to get there?

We've got a lot of the pieces in place to do this, but I don't think we have a way of handling the transformation code yet since that's specific to each SDK. I expect we'll improve these capabilities as part of the multi-language ComponentResource work, but it's mostly manual for now.

@lblackstone lblackstone merged commit 0d9d42d into master Jul 23, 2020
@pulumi-bot pulumi-bot deleted the lblackstone/dotnet-overlay-docs branch July 23, 2020 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants