[python] Add type annotations to overlays #1259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
komalali
approved these changes
Aug 18, 2020
Comment on lines
+21
to
+22
| opts: Optional[pulumi.ResourceOptions] = None, | ||
| __name__=None, |
There was a problem hiding this comment.
Just here to complain about the discrepancy in python's whitespacing convention when there's a type annotation + default value vs. just a default value. Thanks 🐍
lblackstone
reviewed
Aug 18, 2020
| chart: pulumi.Input[str], | ||
| namespace: Optional[pulumi.Input[str]] = None, | ||
| values: Optional[pulumi.Inputs] = None, | ||
| transformations: Optional[pulumi.Inputs] = None, |
There was a problem hiding this comment.
Should we be more specific here? The docstring looks a bit different than this.
There was a problem hiding this comment.
Good catch. Copy/paste mistake. Will fix.
lblackstone
approved these changes
Aug 18, 2020
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #1000