Update .NET Helm v3 to use native client #1291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I still need to update the tests to validate the v2 -> v3 upgrade, and will probably also refactor the ChartBase file to only include stuff shared by v2 and v3. |
lblackstone
commented
Sep 8, 2020
lblackstone
force-pushed
the
lblackstone/dotnet-helm3
branch
from
9e93040
to
da26639
Compare
justinvp
approved these changes
Sep 9, 2020
| }; | ||
| } | ||
| jsonOptsString = JsonSerializer.Serialize(jsonOpts, serializeOptions); | ||
| Console.WriteLine(jsonOptsString); |
There was a problem hiding this comment.
Is this intended to be here, or just leftover from debugging during development?
There was a problem hiding this comment.
Whoops, good catch. Just left over from debugging.
# Conflicts: # tests/sdk/dotnet/dotnet_test.go
lblackstone
force-pushed
the
lblackstone/dotnet-helm3
branch
from
a2f8e5d
to
f5be437
Compare
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Related issues (optional)
Part of #920