Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Python type hints for lists #1313

Merged
merged 1 commit into from
Sep 11, 2020
Merged

Conversation

lblackstone
Copy link
Member

@lblackstone lblackstone commented Sep 10, 2020

Proposed changes

Related issues (optional)

Related to pulumi/pulumi#5283

@lblackstone
Copy link
Member Author

@justinvp Is Tuple ok to use, or does that also need to be remapped to Sequence?

Copy link
Member

@justinvp justinvp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM otherwise

provider/pkg/gen/python-templates/yaml/yaml.tmpl Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@lblackstone lblackstone changed the title Fix Python type hints for arrays and dicts Fix Python type hints for lists Sep 10, 2020
@justinvp
Copy link
Member

@justinvp Is Tuple ok to use, or does that also need to be remapped to Sequence?

Tuple can remain as-is.

@lblackstone lblackstone merged commit f6f4e1b into master Sep 11, 2020
@pulumi-bot pulumi-bot deleted the lblackstone/fix-python-types branch September 11, 2020 00:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants