Fix Helm v3 default namespace handling #1323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
During the switch to native Helm v3 support, the behavior for resources without a specified namespace was changed inadvertently. Rather than specifying the "default" namespace, no namespace was being set. This change correctly sets the namespace in all cases.
lblackstone
force-pushed
the
lblackstone/helmv3-fix
branch
from
d694c12
to
f432b70
Compare
EvanBoyle
approved these changes
Sep 16, 2020
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
During the switch to native Helm v3 support, the behavior
for resources without a specified namespace was changed
inadvertently. Rather than specifying the "default" namespace,
no namespace was being set. This change correctly sets the
namespace in all cases.
Related issues (optional)
Fix #1321