[sdk/nodejs] Add a ready attribute to await Helm Charts

[lblackstone]

Proposed changes

After chatting with @pgavlin about this problem, we determined that Helm Charts were not awaiting properly because child resources are not known at the time the Chart is initialized. The most promising solution appears to be exposing a field on the Chart class that can be passed into the dependsOn option. The existing resources field is a map rather than an array, so we either need to expand dependsOn support to include maps, or create a new field on the Chart class that works with the existing definition.

This PR takes the latter approach, and creates a new .ready field that can be passed directly to the dependsOn option. This change makes dependent resources wait until all Chart subresources are ready as expected. Here's an example program to demonstrate:

import * as k8s from "@pulumi/kubernetes";

const ns = new k8s.core.v1.Namespace("foo")
const chart = new k8s.helm.v3.Chart("nginx", {
    chart: "nginx",
    namespace: ns.metadata.name,
    values: {
        service: {
            type: "ClusterIP"
        }
    },
    fetchOpts: {
        repo: "https://charts.bitnami.com/bitnami"
    },
})

new k8s.core.v1.ConfigMap("test", {
    data: {foo: "bar"}
}, {dependsOn: chart.ready})

Here's what this looks like before/after the change (notice the test ConfigMap gets created immediately on Before):

Before

After

Related issues (optional)

Related to #861

[github-actions]

PR is now waiting for a maintainer to run the acceptance tests. This PR will only perform build and linting.

Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR

[pgavlin]

This looks good to me. Any ideas on how to test this?

[mitchellmaler]

Hey @lblackstone what would the code look like for the python sdk, I am guessing very similar. Wanted to give it a try.

[lblackstone]

Hey @lblackstone what would the code look like for the python sdk, I am guessing very similar. Wanted to give it a try.

I haven't had a chance to work on it yet, but should be the same basic concept. Easiest way to test out would be modifying the relevant Helm/YAML SDK files in your virtualenv

[lblackstone]

Any ideas on how to test this?

I'm not sure yet. I'd like to verify that the ConfigMap isn't created until after all of the Chart resources, but I'm not sure how to get that information. I don't suppose there's an easy way to get timestamps of resource creation events? @pgavlin

[github-actions]

PR is now waiting for a maintainer to run the acceptance tests. This PR will only perform build and linting.

Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR

[lblackstone]

/run-acceptance-tests

[github-actions]

Please view the PR build - https://github.com/pulumi/pulumi-kubernetes/actions/runs/358343347

[lblackstone]

Note: this PR is only for NodeJS. Once this merges, I'll follow with the other SDKs

[github-actions]

PR is now waiting for a maintainer to run the acceptance tests. This PR will only perform build and linting.

Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR

[github-actions]

PR is now waiting for a maintainer to run the acceptance tests. This PR will only perform build and linting.

Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR

[lblackstone]

/run-acceptance-tests

[github-actions]

Please view the PR build - https://github.com/pulumi/pulumi-kubernetes/actions/runs/360140970

[github-actions]

PR is now waiting for a maintainer to run the acceptance tests. This PR will only perform build and linting.

Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR

[komalali]

Ah nice, I was just gonna say the same thing ✅

[lblackstone]

/run-acceptance-tests

[github-actions]

Please view the PR build - https://github.com/pulumi/pulumi-kubernetes/actions/runs/360168574