Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace workload resources on all selector changes #1387

Merged
merged 1 commit into from
Nov 20, 2020
Merged

Replace workload resources on all selector changes #1387

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
## HEAD (Unreleased)

- Replace workload resources if any field in `.spec.selector` changes. (https://github.com/pulumi/pulumi-kubernetes/pull/1387)

## 2.7.2 (November 19, 2020)

- Fixed a gRPC error for larger Helm charts in the .NET SDK [#4224](https://github.com/pulumi/pulumi/issues/4224)
Expand Down
52 changes: 32 additions & 20 deletions provider/pkg/provider/diff.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@ var core = _versions{
".spec.storageClassName",
".spec.volumeName",
},
labelSelectorForceNewProperties(".spec")...),
labelSelectorForceNewProperties(".spec.selector")...),
"Pod": append(
properties{
".spec.affinity",
Expand Down Expand Up @@ -162,20 +162,29 @@ var core = _versions{
},
}

var daemonset = properties{
".spec.selector",
}
var daemonset = append(
properties{
".spec.selector",
},
labelSelectorForceNewProperties(".spec.selector")...,
)

var deployment = properties{
".spec.selector",
}
var deployment = append(
properties{
".spec.selector",
},
labelSelectorForceNewProperties(".spec.selector")...,
)

var job = properties{
".spec.completions",
".spec.parallelism",
".spec.selector",
".spec.template",
}
var job = append(
properties{
".spec.completions",
".spec.parallelism",
".spec.selector",
".spec.template",
},
labelSelectorForceNewProperties(".spec.selector")...,
)

var podDisruptionBudget = properties{
".spec",
Expand All @@ -185,13 +194,16 @@ var roleBinding = properties{
".roleRef",
}

var statefulSet = properties{
".spec.podManagementPolicy",
".spec.revisionHistoryLimit",
".spec.selector",
".spec.serviceName",
".spec.volumeClaimTemplates",
}
var statefulSet = append(
properties{
".spec.podManagementPolicy",
".spec.revisionHistoryLimit",
".spec.selector",
".spec.serviceName",
".spec.volumeClaimTemplates",
},
labelSelectorForceNewProperties(".spec.selector")...,
)

func metadataForceNewProperties(prefix string) properties {
return properties{
Expand Down