Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pulumi deps to v2.15.0 #1393

Merged
merged 1 commit into from
Dec 2, 2020
Merged

Conversation

lblackstone
Copy link
Member

No description provided.

@github-actions
Copy link

github-actions bot commented Dec 2, 2020

PR is now waiting for a maintainer to run the acceptance tests. This PR will only perform build and linting.

Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR

@lblackstone
Copy link
Member Author

/run-acceptance-tests

@github-actions
Copy link

github-actions bot commented Dec 2, 2020

Copy link
Member

@justinvp justinvp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Note that pulumi/pulumi@2606204 was merged after 2.15.0 was tagged (by design so the downstream tests in the PR could run successfully after 2.15.0 was released).

We're going to need to update K8s codegen to use that commit. Did you want to do that as part of this PR, or as a follow-up? When we do that, we'll want to update package.json/setup.py to require @pulumi/pulumi/pulumi 2.15.0 or greater.

@lblackstone
Copy link
Member Author

We're going to need to update K8s codegen to use that commit. Did you want to do that as part of this PR, or as a follow-up? When we do that, we'll want to update package.json/setup.py to require @pulumi/pulumi/pulumi 2.15.0 or greater.

Ah, thanks for clarifying. I guess it makes sense to decouple the changes, so I'll do it as a followup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants