Fix bug with Go Helm v3 transformation marshaling #1420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Helm v3 code was incorrectly trying to marshal transformation functions into JSON before invoking the provider's Helm support. The transformations only execute in the context of the SDK, so the correct behavior is to omit those in the marshaled JSON.
komalali
approved these changes
Jan 11, 2021
viveklak
approved these changes
Jan 11, 2021
viveklak
reviewed
Jan 11, 2021
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
The Helm v3 code was incorrectly trying to marshal transformation functions into JSON before invoking the provider's Helm support. The transformations only execute in the context of the SDK, so the correct behavior is to omit those in the marshaled JSON.
Related issues (optional)
Fix #1369