Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

postpone AdmissionregistrationV1B1 removal #1474

Merged
merged 2 commits into from
Feb 22, 2021
Merged

postpone AdmissionregistrationV1B1 removal #1474

merged 2 commits into from
Feb 22, 2021

Conversation

Iced-Sun
Copy link
Contributor

Proposed changes

Per the comment, the removal of admissionregistration/v1beta1 has been retargeted at 1.22.

Related issues (optional)

Fixes #1388.

@github-actions
Copy link

PR is now waiting for a maintainer to run the acceptance tests. This PR will only perform build and linting.

Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR

@lblackstone
Copy link
Member

/run-acceptance-tests

@github-actions
Copy link

@lblackstone lblackstone self-requested a review February 20, 2021 00:11
@lblackstone
Copy link
Member

@sunbing81 Thanks for the PR! You'll also need to update the related unit test and add a changelog entry to get CI passing.

--- FAIL: TestRemovedInVersion/admissionregistration.k8s.io/v1beta1,_Kind=MutatingWebhookConfiguration (0.00s)

Per [the comment](kubernetes/kubernetes#82021 (comment)), the removal of  `admissionregistration/v1beta1` has been retargeted at 1.22.

Should fix #1388
@github-actions
Copy link

PR is now waiting for a maintainer to run the acceptance tests. This PR will only perform build and linting.

Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR

@lblackstone
Copy link
Member

/run-acceptance-tests

@github-actions
Copy link

@github-actions
Copy link

PR is now waiting for a maintainer to run the acceptance tests. This PR will only perform build and linting.

Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR

@lblackstone
Copy link
Member

LGTM, thanks for the PR @sunbing81!

@loopingrage
Copy link

Upgrading to 2.8.2 resolved this for me... for a couple days. Now the error is back. I confirmed that I'm using 2.8.2 as you can see from an npm ls command and from doing a pulumi up --debug:

Excerpt from pulumi up debug:

    pulumi:pulumi:Stack mapped_infrastructure-dev running debug: registering module kubernetes:admissionregistration.k8s.io/v1@2.8.2
    pulumi:pulumi:Stack mapped_infrastructure-dev running debug: registering module kubernetes:admissionregistration.k8s.io/v1beta1@2.8.2

I also tried deleting the plugin and reinstalling it:

% pulumi plugin rm resource kubernetes           
This will remove 2 plugins from the cache:
    resource kubernetes-2.8.1
    resource kubernetes-2.8.2
Please confirm that this is what you'd like to do by typing ("yes"): yes

% pulumi plugin install resource kubernetes 2.8.2
[resource plugin kubernetes-2.8.2] installing
Downloading plugin: 27.75 MiB / 27.75 MiB [=========================] 100.00% 1s

The odd thing is that after running pulumi up I see that the 2.8.1 plugin is now installed:

kubernetes     resource  2.8.2    70 MB   2 minutes ago   32 seconds ago
kubernetes     resource  2.8.1    70 MB   32 seconds ago  30 seconds ago

There is no mention of 2.8.1 in my pulumi debug log though. How do I begin to troubleshoot this?

@loopingrage
Copy link

I think I found the issue. I did a pulumi stack export and can see that my stack still has references to 2.8.1 which is causing pulumi up to pull in the old version of the provider. What is the recommendation for refreshing my stack with a new provider?

@lblackstone
Copy link
Member

I think I found the issue. I did a pulumi stack export and can see that my stack still has references to 2.8.1 which is causing pulumi up to pull in the old version of the provider. What is the recommendation for refreshing my stack with a new provider?

You should be able to export the state file with pulumi stack export >stack, replace any instances of 2.8.1 with 2.8.2 in the file, and then pulumi stack import --file stack.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

admissionregistration.k8s.io/v1beta1 k8s API error when using pulumi and k8s 1.19
3 participants