Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix helm chart resolution issue #1491

Merged
merged 1 commit into from Mar 10, 2021
Merged

Fix helm chart resolution issue #1491

merged 1 commit into from Mar 10, 2021

Conversation

t0yv0
Copy link
Member

@t0yv0 t0yv0 commented Mar 10, 2021

Proposed changes

Fixes issue with helm chart not found. Originally showed up in examples repo for helm.

Related issues

Test/debug notes

I was reproducing pulumi/examples#938 with a custom-built pulumi-resource-kubernetes (from master) that included instrumentation to spew out the failing Chart parameter, this is what I got:

(*provider.chart)(0xc000603c80)({
 opts: (provider.HelmChartOpts) {
  HelmFetchOpts: (provider.HelmFetchOpts) {
   CAFile: (string) "",
   CertFile: (string) "",
   Destination: (string) "",
   Devel: (bool) false,
   Home: (string) "",
   KeyFile: (string) "",
   Keyring: (string) "",
   Password: (string) "",
   Prov: (bool) false,
   Repo: (string) (len=34) "https://charts.bitnami.com/bitnami",
   UntarDir: (string) "",
   Username: (string) "",
   Verify: (bool) false,
   Version: (string) ""
  },
  APIVersions: ([]string) <nil>,
  Chart: (string) (len=6) "apache",
  IncludeTestHookResources: (bool) false,
  Namespace: (string) "",
  Path: (string) "",
  ReleaseName: (string) (len=6) "apache",
  Repo: (string) (len=7) "bitnami",
  Values: (map[string]interface {}) <nil>,
  Version: (string) (len=5) "1.0.0"
 },
 chartDir: (string) (len=8) "chartdir",
 helmHome: (*string)(<nil>)
})

So presumably the client was passing Repo=bitnami and also HelmFetchOpts.Repo=https://charts.bitnami.com/bitnami together.

Is this a client fault or the pulumi-resource-kubernetes fault? The PR assumes the input is valid but pulumi-reosurce-kubernetes should process it differently. If the input is invalid, let us instead fix the client and harden pulumi-resource-kubernetes to warn appropriately.

Copy link
Member

@lblackstone lblackstone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants