Ensure PULUMI_KUBERNETES_MANAGED_BY_LABEL doesn't cause diffs on updates #1508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: #1357 Before: ``` ▶ PULUMI_KUBERNETES_MANAGED_BY_LABEL=mycompany pulumi up Previewing update (dev) View Live: https://app.pulumi.com/stack72/test-kubernetes-go/dev/previews/9f709e63-1719-4493-8ed5-515882fcc70b Type Name Plan Info pulumi:pulumi:Stack test-kubernetes-go-dev ~ └─ kubernetes:apps/v1:Deployment app-dep update [diff: ~metadata] Resources: ~ 1 to update 1 unchanged Do you want to perform this update? no confirmation declined, not proceeding with the update ``` After: ``` ▶ PULUMI_KUBERNETES_MANAGED_BY_LABEL=mycompany pulumi up Previewing update (dev) View Live: https://app.pulumi.com/stack72/test-kubernetes-go/dev/previews/91ef271f-3000-472f-b41e-b5470d4cca25 Type Name Plan pulumi:pulumi:Stack test-kubernetes-go-dev Resources: 2 unchanged ```
lblackstone
approved these changes
Mar 29, 2021
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #1357
Before:
After:
Proposed changes
Related issues (optional)