[helm] Don't pass opts to child resources #1539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `opts` passed to a component should be passed to it's `super` call, but not to it's children. Child resources automatically inherit those options that they should from their parent - so the resource options applied to a parent should not also be passed down to cildren explicitly. In 3 of the 8 implementations of Helm Chart in this codebase, we were passing the component opts to the children. In the other 5 we were (correctly) not passing them. Fixes #1538
lblackstone
approved these changes
Apr 27, 2021
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
optspassed to a component should be passed to itssupercall, but not to its children. Child resources automatically inherit those options that they should from their parent - so the resource options applied to a parent should not also be passed down to children explicitly.In 3 of the 8 implementations of Helm Chart in this codebase, we were passing the component opts to the children. In the other 5 we were (correctly) not passing them.
Fixes #1538