Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for k8s v1.22 #1551

Merged
merged 3 commits into from
Aug 4, 2021
Merged

Add support for k8s v1.22 #1551

merged 3 commits into from
Aug 4, 2021

Conversation

lblackstone
Copy link
Member

Proposed changes

Note: The alpha EphemeralContainers kind is removed in v1.22

Related issues (optional)

Fix #1550

@github-actions
Copy link

Does the PR have any schema changes?

Found 2 breaking changes:
Resource "kubernetes:core/v1:EphemeralContainers" missing
Type "kubernetes:core/v1:EphemeralContainers" missing

New resources/functions:
kubernetes:policy/v1:Eviction

@github-actions
Copy link

Does the PR have any schema changes?

Found 2 breaking changes:
Resource "kubernetes:core/v1:EphemeralContainers" missing
Type "kubernetes:core/v1:EphemeralContainers" missing
No new resources/functions.

@stack72
Copy link
Contributor

stack72 commented Apr 28, 2021

@lblackstone very cool that our schema-tools did find the actual breaking change!!

for a break like this, how do we handle it for any users that currently use it? Do we leave it in place and deprecate or just yank it with a changelog entry?

@lblackstone
Copy link
Member Author

for a break like this, how do we handle it for any users that currently use it? Do we leave it in place and deprecate or just yank it with a changelog entry?

In this case, it was for an alpha feature that was just added in 1.21, so I think we'll remove it with a breaking change note.

@stack72
Copy link
Contributor

stack72 commented Apr 28, 2021

for a break like this, how do we handle it for any users that currently use it? Do we leave it in place and deprecate or just yank it with a changelog entry?

In this case, it was for an alpha feature that was just added in 1.21, so I think we'll remove it with a breaking change note.

Makes sense - anyway, happy to see that we didn't miss this :)

@github-actions
Copy link

Does the PR have any schema changes?

Found 22 breaking changes:
Resource "kubernetes:core/v1:EphemeralContainers" missing
Resource "kubernetes:networking.k8s.io/v1beta1:IngressClassList" missing
Resource "kubernetes:networking.k8s.io/v1beta1:IngressClass" missing
Type "kubernetes:networking.k8s.io/v1beta1:IngressClass" missing
Type "kubernetes:networking.k8s.io/v1beta1:IngressClassSpec" missing
Type "kubernetes:networking.k8s.io/v1beta1:IngressClassParametersReference" missing
Type "kubernetes:certificates.k8s.io/v1beta1:CertificateSigningRequestCondition" missing property "status"
Type "kubernetes:certificates.k8s.io/v1beta1:CertificateSigningRequestCondition" missing property "lastTransitionTime"
Type "kubernetes:networking.k8s.io/v1beta1:HTTPIngressPath" missing property "pathType"
Type "kubernetes:certificates.k8s.io/v1beta1:CertificateSigningRequestSpec" missing property "signerName"
Type "kubernetes:storage.k8s.io/v1beta1:TokenRequest" missing
Type "kubernetes:extensions/v1beta1:IngressBackend" missing property "resource"
Type "kubernetes:networking.k8s.io/v1beta1:IngressClassList" missing
Type "kubernetes:extensions/v1beta1:HTTPIngressPath" missing property "pathType"
Type "kubernetes:networking.k8s.io/v1beta1:IngressSpec" missing property "ingressClassName"
Type "kubernetes:core/v1:EphemeralContainers" missing
Type "kubernetes:networking.k8s.io/v1beta1:IngressBackend" missing property "resource"
Type "kubernetes:storage.k8s.io/v1beta1:CSIDriverSpec" missing property "storageCapacity"
Type "kubernetes:storage.k8s.io/v1beta1:CSIDriverSpec" missing property "tokenRequests"
Type "kubernetes:storage.k8s.io/v1beta1:CSIDriverSpec" missing property "fsGroupPolicy"
Type "kubernetes:storage.k8s.io/v1beta1:CSIDriverSpec" missing property "requiresRepublish"
Type "kubernetes:extensions/v1beta1:IngressSpec" missing property "ingressClassName"
No new resources/functions.

@github-actions
Copy link

Does the PR have any schema changes?

Found 24 breaking changes:
Resource "kubernetes:networking.k8s.io/v1beta1:IngressClass" missing
Resource "kubernetes:networking.k8s.io/v1beta1:IngressClassList" missing
Resource "kubernetes:core/v1:EphemeralContainers" missing
Type "kubernetes:networking.k8s.io/v1beta1:IngressClass" missing
Type "kubernetes:extensions/v1beta1:IngressSpec" missing property "ingressClassName"
Type "kubernetes:certificates.k8s.io/v1beta1:CertificateSigningRequestCondition" missing property "lastTransitionTime"
Type "kubernetes:certificates.k8s.io/v1beta1:CertificateSigningRequestCondition" missing property "status"
Type "kubernetes:extensions/v1beta1:HTTPIngressPath" missing property "pathType"
Type "kubernetes:certificates.k8s.io/v1beta1:CertificateSigningRequestSpec" missing property "signerName"
Type "kubernetes:networking.k8s.io/v1beta1:IngressSpec" missing property "ingressClassName"
Type "kubernetes:networking.k8s.io/v1beta1:IngressClassSpec" missing
Type "kubernetes:networking.k8s.io/v1beta1:IngressBackend" missing property "resource"
Type "kubernetes:core/v1:EphemeralContainers" missing
Type "kubernetes:networking.k8s.io/v1beta1:IngressClassParametersReference" missing
Type "kubernetes:storage.k8s.io/v1beta1:CSIDriverSpec" missing property "fsGroupPolicy"
Type "kubernetes:storage.k8s.io/v1beta1:CSIDriverSpec" missing property "requiresRepublish"
Type "kubernetes:storage.k8s.io/v1beta1:CSIDriverSpec" missing property "storageCapacity"
Type "kubernetes:storage.k8s.io/v1beta1:CSIDriverSpec" missing property "tokenRequests"
Type "kubernetes:storage.k8s.io/v1beta1:TokenRequest" missing
Type "kubernetes:networking.k8s.io/v1beta1:IngressClassList" missing
Type "kubernetes:apiextensions.k8s.io/v1beta1:CustomResourceDefinitionVersion" missing property "deprecated"
Type "kubernetes:apiextensions.k8s.io/v1beta1:CustomResourceDefinitionVersion" missing property "deprecationWarning"
Type "kubernetes:networking.k8s.io/v1beta1:HTTPIngressPath" missing property "pathType"
Type "kubernetes:extensions/v1beta1:IngressBackend" missing property "resource"
No new resources/functions.

@github-actions
Copy link

Does the PR have any schema changes?

Found 13 breaking changes:
Resource "kubernetes:core/v1:EphemeralContainers" missing
Type "kubernetes:apiextensions.k8s.io/v1beta1:CustomResourceDefinitionVersion" missing property "deprecated"
Type "kubernetes:apiextensions.k8s.io/v1beta1:CustomResourceDefinitionVersion" missing property "deprecationWarning"
Type "kubernetes:certificates.k8s.io/v1beta1:CertificateSigningRequestCondition" missing property "status"
Type "kubernetes:certificates.k8s.io/v1beta1:CertificateSigningRequestCondition" missing property "lastTransitionTime"
Type "kubernetes:core/v1:EphemeralContainers" missing
Type "kubernetes:storage.k8s.io/v1beta1:CSIDriverSpec" missing property "fsGroupPolicy"
Type "kubernetes:storage.k8s.io/v1beta1:CSIDriverSpec" missing property "requiresRepublish"
Type "kubernetes:storage.k8s.io/v1beta1:CSIDriverSpec" missing property "storageCapacity"
Type "kubernetes:storage.k8s.io/v1beta1:CSIDriverSpec" missing property "tokenRequests"
Type "kubernetes:networking.k8s.io/v1beta1:IngressClassSpec" input "parameters" type changed from "#/types/kubernetes:networking.k8s.io/v1beta1:IngressClassParametersReference" to "#/types/kubernetes:core/v1:TypedLocalObjectReference"
Type "kubernetes:networking.k8s.io/v1beta1:IngressClassParametersReference" missing
Type "kubernetes:storage.k8s.io/v1beta1:TokenRequest" missing
No new resources/functions.

@github-actions
Copy link

Does the PR have any schema changes?

Found 13 breaking changes:
Resource "kubernetes:core/v1:EphemeralContainers" missing
Type "kubernetes:storage.k8s.io/v1beta1:TokenRequest" missing
Type "kubernetes:certificates.k8s.io/v1beta1:CertificateSigningRequestCondition" missing property "lastTransitionTime"
Type "kubernetes:certificates.k8s.io/v1beta1:CertificateSigningRequestCondition" missing property "status"
Type "kubernetes:apiextensions.k8s.io/v1beta1:CustomResourceDefinitionVersion" missing property "deprecated"
Type "kubernetes:apiextensions.k8s.io/v1beta1:CustomResourceDefinitionVersion" missing property "deprecationWarning"
Type "kubernetes:core/v1:EphemeralContainers" missing
Type "kubernetes:networking.k8s.io/v1beta1:IngressClassParametersReference" missing
Type "kubernetes:storage.k8s.io/v1beta1:CSIDriverSpec" missing property "requiresRepublish"
Type "kubernetes:storage.k8s.io/v1beta1:CSIDriverSpec" missing property "storageCapacity"
Type "kubernetes:storage.k8s.io/v1beta1:CSIDriverSpec" missing property "tokenRequests"
Type "kubernetes:storage.k8s.io/v1beta1:CSIDriverSpec" missing property "fsGroupPolicy"
Type "kubernetes:networking.k8s.io/v1beta1:IngressClassSpec" input "parameters" type changed from "#/types/kubernetes:networking.k8s.io/v1beta1:IngressClassParametersReference" to "#/types/kubernetes:core/v1:TypedLocalObjectReference"
No new resources/functions.

@github-actions
Copy link

Does the PR have any schema changes?

Found 7 breaking changes:
Resource "kubernetes:core/v1:EphemeralContainers" missing
Type "kubernetes:storage.k8s.io/v1beta1:TokenRequest" missing
Type "kubernetes:networking.k8s.io/v1beta1:IngressClassParametersReference" missing
Type "kubernetes:storage.k8s.io/v1beta1:CSIDriverSpec" missing property "requiresRepublish"
Type "kubernetes:storage.k8s.io/v1beta1:CSIDriverSpec" missing property "tokenRequests"
Type "kubernetes:networking.k8s.io/v1beta1:IngressClassSpec" input "parameters" type changed from "#/types/kubernetes:networking.k8s.io/v1beta1:IngressClassParametersReference" to "#/types/kubernetes:core/v1:TypedLocalObjectReference"
Type "kubernetes:core/v1:EphemeralContainers" missing
No new resources/functions.

@github-actions
Copy link

Does the PR have any schema changes?

Found 4 breaking changes:
Resource "kubernetes:core/v1:EphemeralContainers" missing
Type "kubernetes:networking.k8s.io/v1beta1:IngressClassParametersReference" missing
Type "kubernetes:networking.k8s.io/v1beta1:IngressClassSpec" input "parameters" type changed from "#/types/kubernetes:networking.k8s.io/v1beta1:IngressClassParametersReference" to "#/types/kubernetes:core/v1:TypedLocalObjectReference"
Type "kubernetes:core/v1:EphemeralContainers" missing
No new resources/functions.

@github-actions
Copy link

Does the PR have any schema changes?

Found 4 breaking changes:
Resource "kubernetes:core/v1:EphemeralContainers" missing
Type "kubernetes:core/v1:EphemeralContainers" missing
Type "kubernetes:networking.k8s.io/v1beta1:IngressClassSpec" input "parameters" type changed from "#/types/kubernetes:networking.k8s.io/v1beta1:IngressClassParametersReference" to "#/types/kubernetes:core/v1:TypedLocalObjectReference"
Type "kubernetes:networking.k8s.io/v1beta1:IngressClassParametersReference" missing
No new resources/functions.

@github-actions
Copy link

Does the PR have any schema changes?

Found 4 breaking changes:
Resource "kubernetes:core/v1:EphemeralContainers" missing
Type "kubernetes:networking.k8s.io/v1beta1:IngressClassParametersReference" missing
Type "kubernetes:networking.k8s.io/v1beta1:IngressClassSpec" input "parameters" type changed from "#/types/kubernetes:networking.k8s.io/v1beta1:IngressClassParametersReference" to "#/types/kubernetes:core/v1:TypedLocalObjectReference"
Type "kubernetes:core/v1:EphemeralContainers" missing
No new resources/functions.

@lblackstone lblackstone marked this pull request as ready for review July 30, 2021 20:23
@lblackstone
Copy link
Member Author

@viveklak @mikhailshilkov This PR should be ready for the August 4 release date. I've already updated the changelog to note the breaking changes, so you will just need to verify that nothing else has changed when you update the Makefile release to v1.22.0.

@github-actions
Copy link

Does the PR have any schema changes?

Found 4 breaking changes:
Resource "kubernetes:core/v1:EphemeralContainers" missing
Type "kubernetes:networking.k8s.io/v1beta1:IngressClassParametersReference" missing
Type "kubernetes:networking.k8s.io/v1beta1:IngressClassSpec" input "parameters" type changed from "#/types/kubernetes:networking.k8s.io/v1beta1:IngressClassParametersReference" to "#/types/kubernetes:core/v1:TypedLocalObjectReference"
Type "kubernetes:core/v1:EphemeralContainers" missing
No new resources/functions.

@justinvp
Copy link
Member

justinvp commented Aug 4, 2021

@mikhailshilkov, @viveklak, before we release a new version of the k8s provider (I assume we'll be doing a release after adopting v1.22.0), we'll want #1664 merged, otherwise the version in the Python package will be incorrect.

@viveklak
Copy link
Contributor

viveklak commented Aug 4, 2021

@mikhailshilkov, @viveklak, before we release a new version of the k8s provider (I assume we'll be doing a release after adopting v1.22.0), we'll want #1664 merged, otherwise the version in the Python package will be incorrect.

Thanks rebased on top of master after merging #1664.

@github-actions
Copy link

github-actions bot commented Aug 4, 2021

Does the PR have any schema changes?

Found 4 breaking changes:
Resource "kubernetes:core/v1:EphemeralContainers" missing
Type "kubernetes:networking.k8s.io/v1beta1:IngressClassSpec" input "parameters" type changed from "#/types/kubernetes:networking.k8s.io/v1beta1:IngressClassParametersReference" to "#/types/kubernetes:core/v1:TypedLocalObjectReference"
Type "kubernetes:networking.k8s.io/v1beta1:IngressClassParametersReference" missing
Type "kubernetes:core/v1:EphemeralContainers" missing
No new resources/functions.

@viveklak viveklak requested a review from stack72 August 4, 2021 20:07
@github-actions
Copy link

github-actions bot commented Aug 4, 2021

Does the PR have any schema changes?

Found 4 breaking changes:
Resource "kubernetes:core/v1:EphemeralContainers" missing
Type "kubernetes:networking.k8s.io/v1beta1:IngressClassSpec" input "parameters" type changed from "#/types/kubernetes:networking.k8s.io/v1beta1:IngressClassParametersReference" to "#/types/kubernetes:core/v1:TypedLocalObjectReference"
Type "kubernetes:networking.k8s.io/v1beta1:IngressClassParametersReference" missing
Type "kubernetes:core/v1:EphemeralContainers" missing
No new resources/functions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support k8s v1.22 on release
4 participants