Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sdk/nodejs] Avoid circular dependencies in modules #1558

Merged
merged 4 commits into from
May 3, 2021

Conversation

lukehoban
Copy link
Member

We had a circular dependency due to the ./yaml module importing the full root module. This led to issues like #1422. At least in the specific case that triggered that error - we do not need to introduce the cycle.

Fixes #1422.

We had a circular dependency due to the `./yaml` module importing the full root module.  This led to issues like #1422.  At least in the specific case that triggered that error - we do not need to introduce the cycle.

Fixes #1422.
@github-actions
Copy link

github-actions bot commented May 1, 2021

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

@lukehoban lukehoban requested a review from lblackstone May 1, 2021 01:10
@github-actions
Copy link

github-actions bot commented May 3, 2021

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

1 similar comment
@github-actions
Copy link

github-actions bot commented May 3, 2021

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

@github-actions
Copy link

github-actions bot commented May 3, 2021

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

1 similar comment
@github-actions
Copy link

github-actions bot commented May 3, 2021

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

@github-actions
Copy link

github-actions bot commented May 3, 2021

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using helm.v3.Chart via "@pulumi/kubernetes/helm/v3" throws TypeError
2 participants