Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make CRD rendering conditional for Helm v3 #1572

Merged
merged 11 commits into from
May 13, 2021
Merged

Make CRD rendering conditional for Helm v3 #1572

merged 11 commits into from
May 13, 2021

Conversation

viveklak
Copy link
Contributor

Fixes #1195

@viveklak viveklak requested a review from lblackstone May 12, 2021 06:17
@viveklak viveklak changed the title Make CRD rendering conditional Make CRD rendering conditional for Helm v3 May 12, 2021
@github-actions
Copy link

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

@viveklak viveklak mentioned this pull request May 12, 2021
Closed
@github-actions
Copy link

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

lblackstone
lblackstone reviewed May 12, 2021
View reviewed changes
Copy link
Member

@lblackstone lblackstone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall!

tests/sdk/go/go_test.go
@@ -26,7 +26,7 @@ import (
var baseOptions = &integration.ProgramTestOptions{
Verbose: true,
Dependencies: []string{
"github.com/pulumi/pulumi-kubernetes/sdk/v3/go",
"github.com/pulumi/pulumi-kubernetes/sdk/v3",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is right. Pretty sure I had to change this recently to get tests passing.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was running into issues getting the test to run locally without this since the test framework installs a replace block mapping to pulumi/pulumi-kubernetes/sdk/go which doesn't have a go.mod. It did work locally with the above change but the CI run is failing. Will investigate.

tests/sdk/go/go_test.go Outdated Show resolved Hide resolved
tests/sdk/python/helm-skip-crd-rendering/step1/__main__.py Outdated Show resolved Hide resolved
@github-actions
Copy link

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

1 similar comment
@github-actions
Copy link

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

@github-actions
Copy link

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

@github-actions
Copy link

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

@github-actions
Copy link

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

1 similar comment
@github-actions
Copy link

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

@viveklak viveklak merged commit 359b746 into master May 13, 2021
@pulumi-bot pulumi-bot deleted the vl/SkipCRDRendering branch May 13, 2021 04:30
@renovate renovate bot mentioned this pull request May 21, 2021
Open
1 task
@renovate renovate bot mentioned this pull request Jun 6, 2021
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lblackstone lblackstone lblackstone approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow to toggle CRDs installation when using Helm3
2 participants
@viveklak @lblackstone