Fix diff panic for malformed kubeconfig #1581
Conversation
If the kubeconfig context name was not indented properly, it could lead to a map lookup failing, and then a subsequent unchecked nil value.
Does the PR have any schema changes?Looking good! No breaking changes found. |
| if activeContext == nil { | ||
| return &clientapi.Cluster{} | ||
| } | ||
| activeClusterName := activeContext.Cluster | ||
|
|
||
| activeCluster := config.Clusters[activeClusterName] |
There was a problem hiding this comment.
Can the same issue occur here as well?
There was a problem hiding this comment.
Looks like it. Good catch.
| activeClusterName := config.Contexts[currentContext].Cluster | ||
| activeContext := config.Contexts[currentContext] | ||
| if activeContext == nil { | ||
| return &clientapi.Cluster{} |
There was a problem hiding this comment.
This means we don't report up a useful error about what caused this. Should this function return a useful error?
There was a problem hiding this comment.
I'm not sure it's possible to tell if this is actually an error since this runs during preview and Outputs may not yet be fully resolved. I suspect that it might lead to erroneous warnings.
This particular case was a bit odd because the outdented YAML still parsed cleanly, but changed the semantics of the configuration. This change fixes the panic, and now correctly shows a replacement in the preview. This should be sufficient for a user to notice that something is going wrong if they weren't expecting a change.
Does the PR have any schema changes?Looking good! No breaking changes found. |
1 similar comment
Does the PR have any schema changes?Looking good! No breaking changes found. |
Proposed changes
If the kubeconfig context name was not indented
properly, it could lead to a map lookup failing, and
then a subsequent unchecked nil value.
Related issues (optional)
Fix #1543