Handle auto-named namespaces for server-side diff #1633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Does the PR have any schema changes?Looking good! No breaking changes found. |
lblackstone
force-pushed
the
lblackstone/ssa-namespace-bug
branch
from
917251e
to
c19f341
Compare
Does the PR have any schema changes?Looking good! No breaking changes found. |
1 similar comment
Does the PR have any schema changes?Looking good! No breaking changes found. |
This fixes a bug with server-side diff support where auto-named namespaces would cause resources using that namespace to fail during preview. This was caused by configuring the k8s client to run a server-side preview on a namespace that didn't yet exist.
lblackstone
force-pushed
the
lblackstone/ssa-namespace-bug
branch
from
c19f341
to
97af1ee
Compare
Does the PR have any schema changes?Looking good! No breaking changes found. |
2 similar comments
Does the PR have any schema changes?Looking good! No breaking changes found. |
Does the PR have any schema changes?Looking good! No breaking changes found. |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This fixes a bug with server-side diff support where auto-named
namespaces would cause resources using that namespace to
fail during preview. This was caused by configuring the k8s client
to run a server-side preview on a namespace that didn't yet exist.
Related issues (optional)
Fix #1632