Nest Helm Release settings #1751
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Does the PR have any schema changes?Looking good! No breaking changes found. |
1 similar comment
Does the PR have any schema changes?Looking good! No breaking changes found. |
lblackstone
force-pushed
the
lblackstone/nest-release-settings
branch
from
dc5c6b2
to
6cd7761
Compare
Does the PR have any schema changes?Looking good! No breaking changes found. |
|
Marking as draft until I've fixed the env var handling. |
Does the PR have any schema changes?Looking good! No breaking changes found. |
| @@ -974,6 +1037,7 @@ func init() { | |||
| typeOverlays["kubernetes:helm.sh/v3:RepositoryOpts"] = helmV3RepoOpts | |||
| typeOverlays["kubernetes:helm.sh/v3:ReleaseStatus"] = helmV3ReleaseStatus | |||
| typeOverlays["kubernetes:index:KubeClientSettings"] = kubeClientSettings | |||
| typeOverlays["kubernetes:index:HelmReleaseSettings"] = helmReleaseSettings | |||
There was a problem hiding this comment.
Should these be in helm.sh/v3 module?
There was a problem hiding this comment.
No, this type is for the Provider, so it needs to be at the top level.
# Conflicts: # CHANGELOG.md
Does the PR have any schema changes?Looking good! No breaking changes found. |
viveklak
approved these changes
Oct 6, 2021
Does the PR have any schema changes?Looking good! No breaking changes found. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Move helm.Release Provider options into a complex type to avoid cluttering
the top-level namespace.
Related issues (optional)
Fix #1746