Change await logic client to use target apiVersion on update #1758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the await logic used the previous apiVersion of a resource to issue requests to the API server. In the case of API changes, this could cause errors. Newer apiVersions should be backward compatible, so switch to using the target apiVersion of a resource instead.
Does the PR have any schema changes?Looking good! No breaking changes found. |
|
I confirmed that this change fixes both linked issues. |
Does the PR have any schema changes?Looking good! No breaking changes found. |
viveklak
approved these changes
Oct 5, 2021
This was referenced Feb 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Previously, the await logic used the previous apiVersion of a
resource to issue requests to the API server. In the case of
API changes, this could cause errors. Newer apiVersions should
be backward compatible, so switch to using the target apiVersion
of a resource instead.
Related issues (optional)
Fix #1668
Fix #1734