Relax PyYaml dependency #1768
Merged
Relax PyYaml dependency #1768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikhailshilkov
approved these changes
Oct 15, 2021
komalali
approved these changes
Oct 15, 2021
Does the PR have any schema changes?Looking good! No breaking changes found. |
1 similar comment
Does the PR have any schema changes?Looking good! No breaking changes found. |
|
Heh looks like it's generated code? |
Does the PR have any schema changes?Looking good! No breaking changes found. |
I know 🤦🏾♂️... Fixed! |
komalali
reviewed
Oct 15, 2021
| @@ -45648,7 +45648,7 @@ | |||
| "readme": "The Kubernetes provider package offers support for all Kubernetes resources and their properties.\nResources are exposed as types from modules based on Kubernetes API groups such as 'apps', 'core',\n'rbac', and 'storage', among many others. Additionally, support for deploying Helm charts ('helm')\nand YAML files ('yaml') is available in this package. Using this package allows you to\nprogrammatically declare instances of any Kubernetes resources and any supported resource version\nusing infrastructure as code, which Pulumi then uses to drive the Kubernetes API.\n\nIf this is your first time using this package, these two resources may be helpful:\n\n* [Kubernetes Getting Started Guide](https://www.pulumi.com/docs/quickstart/kubernetes/): Get up and running quickly.\n* [Kubernetes Pulumi Setup Documentation](https://www.pulumi.com/docs/quickstart/kubernetes/configure/): How to configure Pulumi\n for use with your Kubernetes cluster.\n", | |||
| "requires": { | |||
| "pulumi": "\u003e=3.0.0,\u003c4.0.0", | |||
| "pyyaml": "\u003e=5.3.1,\u003c6.0", | |||
| "pyyaml": "\u003e=5.3.1", | |||
There was a problem hiding this comment.
btw, this happens because we don't use encoder.SetEscapeHTML(false).
https://pkg.go.dev/encoding/json#Encoder.SetEscapeHTML
Maybe we should be doing that? cc @pgavlin
There was a problem hiding this comment.
Oof. Yeah, seems like we should do that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Relax PyYaml dependency.
Related issues (optional)
Fixes #1767