[sdk/python] Add ready attribute to await Helm charts #1782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Does the PR have any schema changes?Looking good! No breaking changes found. |
Does the PR have any schema changes?Looking good! No breaking changes found. |
Does the PR have any schema changes?Looking good! No breaking changes found. |
viveklak
reviewed
Nov 1, 2021
| @@ -1 +1 @@ | |||
| pulumi>=2.0.0,<3.0.0 | |||
| pulumi>=3.0.0,<4.0.0 | |||
There was a problem hiding this comment.
Does this need to be >= 3.9.0 as well?
There was a problem hiding this comment.
Yeah, but I figured I'd leave it as is so that it's easier to find/replace when 4.0 rolls around.
viveklak
reviewed
Nov 1, 2021
| @@ -360,6 +361,34 @@ func TestHelmLocal(t *testing.T) { | |||
| } | |||
| options := baseOptions.With(integration.ProgramTestOptions{ | |||
| Dir: filepath.Join(cwd, "helm-local", "step1"), | |||
| ExtraRuntimeValidation: func(t *testing.T, stackInfo integration.RuntimeValidationStackInfo) { | |||
There was a problem hiding this comment.
This is neat! DId you verify this fails before the fix?
There was a problem hiding this comment.
Yep! Without the fix, both ConfigMap resources will create before the Deployment and Service.
viveklak
approved these changes
Nov 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Related issues (optional)
Part of #861