Schematize overlay types #1793
Merged
Schematize overlay types #1793
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lblackstone
force-pushed
the
lblackstone/overlay-schema
branch
from
9352267
to
37c5259
Compare
This comment has been minimized.
This comment has been minimized.
1 similar comment
Does the PR have any schema changes?Looking good! No breaking changes found. New resources:
|
This comment has been minimized.
This comment has been minimized.
1 similar comment
Does the PR have any schema changes?Looking good! No breaking changes found. New resources:
|
lblackstone
force-pushed
the
lblackstone/overlay-schema
branch
from
dbcc2f9
to
453c191
Compare
This comment has been minimized.
This comment has been minimized.
lblackstone
force-pushed
the
lblackstone/overlay-schema
branch
from
453c191
to
5de1ae6
Compare
This comment has been minimized.
This comment has been minimized.
3 similar comments
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Does the PR have any schema changes?Looking good! No breaking changes found. New resources:
|
Previously, overlay types (CustomResource, kustomize, helm, yaml) were not included in the provider schema, and were documented manually. This change adds these resources and types to the schema with the IsOverlay flag set so that they can be referenced by the docs generator and provider codegen.
lblackstone
force-pushed
the
lblackstone/overlay-schema
branch
from
74a4287
to
dbd4323
Compare
Does the PR have any schema changes?Looking good! No breaking changes found. New resources:
|
viveklak
reviewed
Nov 12, 2021
| @@ -13,7 +13,7 @@ | |||
| import requests | |||
There was a problem hiding this comment.
Doesn't the change in namespace affect things like ConfigGroup usage etc. for users?
There was a problem hiding this comment.
It's still exported at the top level as before, so the path shouldn't matter. I didn't have to change any of the tests after this change.
There was a problem hiding this comment.
ah ok - missed that. LGTM
viveklak
approved these changes
Nov 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Previously, overlay types (CustomResource, kustomize, helm, yaml)
were not included in the provider schema, and were documented
manually. This change adds these resources and types to the schema
with the IsOverlay flag set so that they can be referenced by the docs
generator and provider codegen.
Related issues (optional)
Codegen and schema changes: pulumi/pulumi#8338
Docs PR using these changes: pulumi/docs#6777