Add support for using values from yaml files #1828
Conversation
Does the PR have any schema changes?Looking good! No breaking changes found. |
1 similar comment
Does the PR have any schema changes?Looking good! No breaking changes found. |
viveklak
requested review from
lblackstone,
danielrbradley and
mikhailshilkov
Does the PR have any schema changes?Looking good! No breaking changes found. |
| if err := mapstructure.Decode(stripped, &release); err != nil { | ||
| return nil, fmt.Errorf("decoding failure: %w", err) | ||
| } | ||
| release.Values = mergeMaps(release.Values, values) |
There was a problem hiding this comment.
The precedence - if it's not clear - will prioritize the values in the values field over what is specified in the files.
| return nil, err | ||
| } | ||
| default: | ||
| return nil, fmt.Errorf("unsupported type for 'valueYamlFiles' arg: %T", v) |
There was a problem hiding this comment.
Do we want to also support Archives? I just noticed that the SDK type supports both Assets and Archives.
There was a problem hiding this comment.
Trying to keep this in-line with the helm CLI. The CLI takes yaml files and not archives. We can reconsider if we get requests from users. I can't think of an obvious use case where archives would be preferred.
Good catch! Updated now. |
Does the PR have any schema changes?Looking good! No breaking changes found. |
Proposed changes
Related issues (optional)
Fixes #1700