Populate inputs from live state for imports #1846
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Does the PR have any schema changes?Looking good! No breaking changes found. |
lblackstone
approved these changes
Jan 4, 2022
Yes - correct. |
viveklak
force-pushed
the
vl/ImportWithInputs
branch
from
31d1f41
to
51b32fa
Compare
Does the PR have any schema changes?Looking good! No breaking changes found. |
1 similar comment
Does the PR have any schema changes?Looking good! No breaking changes found. |
Co-authored-by: Levi Blackstone <levi@pulumi.com>
viveklak
force-pushed
the
vl/ImportWithInputs
branch
from
51b32fa
to
5716a5e
Compare
Does the PR have any schema changes?Looking good! No breaking changes found. |
viveklak
force-pushed
the
vl/ImportWithInputs
branch
from
5716a5e
to
b74ef30
Compare
Does the PR have any schema changes?Looking good! No breaking changes found. |
1 similar comment
Does the PR have any schema changes?Looking good! No breaking changes found. |
viveklak
force-pushed
the
vl/ImportWithInputs
branch
from
e7f0662
to
a1b1898
Compare
Does the PR have any schema changes?Looking good! No breaking changes found. |
Does the PR have any schema changes?Looking good! No breaking changes found. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This change proposes an approach where we do a best-effort attempt at populating inputs from the live state for imports. Even though we tag input properties in the schema, we often have nested input fields mixed-in with dynamically populated fields so I am not entirely convinced this is the right approach. Curious to hear thoughts here.
Related issues (optional)
Fixes #1410.