Change await log type to cloud-ready-check lib #1855
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Does the PR have any schema changes?Looking good! No breaking changes found. |
2 similar comments
Does the PR have any schema changes?Looking good! No breaking changes found. |
Does the PR have any schema changes?Looking good! No breaking changes found. |
The cloud-ready-check library includes an identical logging.Message type definition, so remove the type from the provider and update all references to use the external type instead.
lblackstone
force-pushed
the
lblackstone/external-logger-defs
branch
from
95c9674
to
4166b9f
Compare
Does the PR have any schema changes?Looking good! No breaking changes found. |
viveklak
reviewed
Jan 6, 2022
| @@ -1,4 +1,4 @@ | |||
| // Copyright 2016-2019, Pulumi Corporation. | |||
| // Copyright 2016-2022, Pulumi Corporation. | |||
There was a problem hiding this comment.
Should this file be in cloud-ready-checks instead?
There was a problem hiding this comment.
I think this logic is more specific to provider logging, so I decided to leave it here. The await library returns the messages and it's up to the client how to handle them.
| @@ -1,4 +1,4 @@ | |||
| // Copyright 2016-2019, Pulumi Corporation. | |||
| @@ -1,4 +1,4 @@ | |||
| // Copyright 2016-2019, Pulumi Corporation. | |||
viveklak
approved these changes
Jan 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
The cloud-ready-check library includes an identical
logging.Message type definition, so remove the type
from the provider and update all references to use the
external type instead.
Related issues (optional)