Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch Pod and Job await logic to external lib #1856

Merged
merged 3 commits into from
Jan 12, 2022
Merged

Switch Pod and Job await logic to external lib #1856

merged 3 commits into from
Jan 12, 2022

Conversation

lblackstone
Copy link
Member

Proposed changes

Related issues (optional)

@github-actions
Copy link

github-actions bot commented Jan 5, 2022

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

4 similar comments
@github-actions
Copy link

github-actions bot commented Jan 5, 2022

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

@github-actions
Copy link

github-actions bot commented Jan 5, 2022

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

@github-actions
Copy link

github-actions bot commented Jan 5, 2022

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

@github-actions
Copy link

github-actions bot commented Jan 5, 2022

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

@github-actions
Copy link

github-actions bot commented Jan 6, 2022

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

@lblackstone lblackstone marked this pull request as ready for review January 6, 2022 01:08
@github-actions
Copy link

github-actions bot commented Jan 6, 2022

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

1 similar comment
@github-actions
Copy link

github-actions bot commented Jan 6, 2022

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

@github-actions
Copy link

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

1 similar comment
@github-actions
Copy link

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

@lblackstone
Copy link
Member Author

ping @viveklak

@github-actions
Copy link

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

1 similar comment
@github-actions
Copy link

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

stack72
stack72 approved these changes Jan 12, 2022
View reviewed changes
Copy link
Contributor

@stack72 stack72 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love deleting code!! :D Thanks!

@lblackstone lblackstone merged commit 1105b0f into master Jan 12, 2022
@pulumi-bot pulumi-bot deleted the lblackstone/await-lib branch January 12, 2022 23:18
@lblackstone lblackstone mentioned this pull request Feb 1, 2023
Closed
@squaremo squaremo mentioned this pull request Feb 3, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stack72 stack72 stack72 approved these changes

@viveklak viveklak Awaiting requested review from viveklak

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lblackstone @stack72