Elide last applied configuration annotation when SSA is supported #1863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Does the PR have any schema changes?Looking good! No breaking changes found. |
lblackstone
approved these changes
Jan 7, 2022
Does the PR have any schema changes?Looking good! No breaking changes found. |
3 similar comments
Does the PR have any schema changes?Looking good! No breaking changes found. |
Does the PR have any schema changes?Looking good! No breaking changes found. |
Does the PR have any schema changes?Looking good! No breaking changes found. |
viveklak
force-pushed
the
vl/DryRunDisableLastApplied
branch
from
a9e039a
to
87b009f
Compare
Does the PR have any schema changes?Looking good! No breaking changes found. |
kaz130
added a commit
to qmonus/pulumi-kubernetes
that referenced
this pull request
Jun 15, 2023
…rted (pulumi#1863)" This reverts commit 11e356e.
kaz130
added a commit
to qmonus/pulumi-kubernetes
that referenced
this pull request
Jun 15, 2023
kaz130
added a commit
to qmonus/pulumi-kubernetes
that referenced
this pull request
Jun 15, 2023
kaz130
added a commit
to qmonus/pulumi-kubernetes
that referenced
this pull request
Jun 15, 2023
…rted (pulumi#1863)" This reverts commit 11e356e.
kaz130
added a commit
to qmonus/pulumi-kubernetes
that referenced
this pull request
Jun 16, 2023
kaz130
added a commit
to qmonus/pulumi-kubernetes
that referenced
this pull request
Jun 19, 2023
…rted (pulumi#1863)" This reverts commit 11e356e.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
When server side applies are supported, storing last applied configuration seems redundant. We have longstanding plans of toggling server side apply support to be on by default - see #1556. This change elides last applied config annotation when server-side apply support is enabled. This seems safe since SSA support is not enabled by default anyway thus reducing any potential risk of unexpected behavior change with this.
Related issues (optional)
Fixes #1048