Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't use the last-applied-configuration annotation for CRDs #1882

Merged
merged 4 commits into from
May 25, 2022
Merged

Don't use the last-applied-configuration annotation for CRDs #1882

merged 4 commits into from
May 25, 2022

Conversation

lblackstone
Copy link
Member

@lblackstone lblackstone commented Jan 21, 2022 •
edited
Loading

Proposed changes

Related issues (optional)

Fix #1883

@github-actions
Copy link

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

1 similar comment
@github-actions
Copy link

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

@gitfool gitfool mentioned this pull request Mar 31, 2022
Closed
@lblackstone lblackstone force-pushed the lblackstone/crd-annotation-fix branch from cb0a18a to 61140ba Compare May 24, 2022 22:42
@lblackstone lblackstone force-pushed the lblackstone/crd-annotation-fix branch from 61140ba to f2494e2 Compare May 24, 2022 22:43
@lblackstone lblackstone marked this pull request as ready for review May 24, 2022 22:44
@github-actions
Copy link

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

@github-actions github-actions bot added the impact/no-changelog-required This issue doesn't require a CHANGELOG update label May 24, 2022
@github-actions
Copy link

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

@github-actions
Copy link

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

@lblackstone lblackstone requested a review from viveklak May 24, 2022 22:57
viveklak
viveklak reviewed May 25, 2022
View reviewed changes
CHANGELOG.md
@@ -5,6 +5,7 @@ Note: The `kubernetes:helm/v2:Chart` API was deprecated in this update and will
updates.

- Deprecate helm/v2:Chart resources (https://github.com/pulumi/pulumi-kubernetes/pull/1990)
- Don't use the last-applied-configuration annotation for CRDs (https://github.com/pulumi/pulumi-kubernetes/pull/1882)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we verify if this obviates the enableReplaceCRD flag? In which case lets remove and call it out explicitly in the changelog.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! I verified that the enableReplaceCRD option is no longer required, and added a deprecation notice to clarify that it is no longer used and will be removed in the future.

@github-actions
Copy link

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

@lblackstone lblackstone merged commit 308be3d into master May 25, 2022
@pulumi-bot pulumi-bot deleted the lblackstone/crd-annotation-fix branch May 25, 2022 18:00
@kaz130 kaz130 mentioned this pull request Jun 16, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@viveklak viveklak viveklak approved these changes

Assignees
No one assigned
Labels
impact/no-changelog-required This issue doesn't require a CHANGELOG update
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CRD update fails if last-applied-configuration annotation too long
2 participants
@lblackstone @viveklak