[Helm/Release] Add examples to API reference docs and sdks #1887
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viveklak
force-pushed
the
vl/AddReleaseAPIDocs
branch
from
0ce4caa
to
fc1c5aa
Compare
Does the PR have any schema changes?Looking good! No breaking changes found. |
1 similar comment
Does the PR have any schema changes?Looking good! No breaking changes found. |
lblackstone
approved these changes
Jan 27, 2022
Comment on lines
574
to
580
| "cluster": pulumi.Map{ | ||
| "enabled": pulumi.Bool(true), | ||
| }, | ||
| "rbac": pulumi.Map{ | ||
| "create": pulumi.Bool(true), | ||
| }, | ||
| }, |
There was a problem hiding this comment.
Looks like the indentation is wrong here
There was a problem hiding this comment.
Thanks for pointing out! Fixed now.
Does the PR have any schema changes?Looking good! No breaking changes found. |
lblackstone
reviewed
Jan 27, 2022
Does the PR have any schema changes?Looking good! No breaking changes found. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This change adds a number of reference examples for using Helm Release resource to API docs and SDK docstrings.
Related issues (optional)
Fixes #1695