Fix an error handling bug in await logic #1899
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Does the PR have any schema changes?Looking good! No breaking changes found. |
This code was missing an err check based on the mistaken assumption that it would be checked following the conditional block. This wasn't working as intended due to block scoping.
lblackstone
force-pushed
the
lblackstone/bug-fix
branch
from
cda4e90
to
ed3aaa2
Compare
lblackstone
changed the title
Does the PR have any schema changes?Looking good! No breaking changes found. |
|
This may also be related to #1883 I think the update would have failed if the annotation was too long rather than silently passing. |
stack72
approved these changes
Feb 9, 2022
|
I'm actually surprised that go lint didn't pick this up as an unchecked error! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This code was missing an err check based on the mistaken assumption that it would be checked following the conditional block. This wasn't working as intended due to block scoping.
Related issues (optional)