Update Kubernetes support to Kubernetes v1.24.0 #1911
Conversation
Does the PR have any schema changes?Looking good! No breaking changes found. |
viveklak
added
the
impact/no-changelog-required
Does the PR have any schema changes?Found 4 breaking changes: New resources:
|
|
@lblackstone looks like v1alpha1:CSIStorageCapacity and v1alpha1:CSIStorageCapacityList are no longer being served in 1.24 - kubernetes/kubernetes#109151 (comment). Do we need to add it to the deprecated.go file? |
| @@ -32,7 +32,7 @@ ensure:: | |||
| cd tests && go mod tidy | |||
|
|
|||
| k8sgen:: | |||
| (cd provider && CGO_ENABLED=0 go build -o $(WORKING_DIR)/bin/${CODEGEN} -ldflags "-X ${PROJECT}/${VERSION_PATH}=${VERSION}" ${PROJECT}/${PROVIDER_PATH}/cmd/$(CODEGEN)) | |||
| (cd provider && CGO_ENABLED=1 go build -o $(WORKING_DIR)/bin/${CODEGEN} -ldflags "-X ${PROJECT}/${VERSION_PATH}=${VERSION}" ${PROJECT}/${PROVIDER_PATH}/cmd/$(CODEGEN)) | |||
There was a problem hiding this comment.
Looks like the github.com/rjeczalik/notify CGO switch is also affecting us here.
There was a problem hiding this comment.
We will need to update goreleaser here
There was a problem hiding this comment.
Maybe we pull this out and make the fixes to the build system separately rather than getting stuck behind the 1.24.0 release?
Yeah, we should update the deprecation logic, and also want to make sure that thew v1alpha1 version is included in the list of aliases. It looks like it's not because the API was removed, so we'll need to patch that in. |
Yeah we should add the alias. Sounds good, will do! We still have time it seems for the 1.24.0 release (May 3rd) |
lblackstone
force-pushed
the
vl/WIP1.24.0
branch
2 times, most recently
from
9e90714
to
eec8cfc
Compare
Does the PR have any schema changes?Found 4 breaking changes: New resources:
|
Does the PR have any schema changes?Found 4 breaking changes: New resources:
|
Does the PR have any schema changes?Found 4 breaking changes: New resources:
|
lblackstone
changed the title
Does the PR have any schema changes?Looking good! No breaking changes found. |
Proposed changes
Related issues (optional)