Fix DaemonSet name on diff #1951
Conversation
|
PR is now waiting for a maintainer to run the acceptance tests. This PR will only perform build and linting. Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR |
1 similar comment
|
PR is now waiting for a maintainer to run the acceptance tests. This PR will only perform build and linting. Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR |
|
Also, this If the maintainers are fine with that, I could do this change as well. |
|
/run-acceptance-tests |
|
Please view the PR build - https://github.com/pulumi/pulumi-kubernetes/actions/runs/2092465691 |
|
Thanks for the PR! Do you also have a sample program you can use to demonstrate the fix? I am happy to help you convert that to an integration test. |
|
PR is now waiting for a maintainer to run the acceptance tests. This PR will only perform build and linting. Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR |
Just added the integration tests, but don't know if it was the best way of verifying if the DaemonSet was replaced when changing the |
alexrocco
force-pushed
the
alexrocco/fix-daemonset-diff-name
branch
from
e6642a8
to
ca6d5a7
Compare
|
PR is now waiting for a maintainer to run the acceptance tests. This PR will only perform build and linting. Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR |
alexrocco
force-pushed
the
alexrocco/fix-daemonset-diff-name
branch
2 times, most recently
from
e59a141
to
7a676ed
Compare
|
PR is now waiting for a maintainer to run the acceptance tests. This PR will only perform build and linting. Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR |
1 similar comment
|
PR is now waiting for a maintainer to run the acceptance tests. This PR will only perform build and linting. Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR |
alexrocco
force-pushed
the
alexrocco/fix-daemonset-diff-name
branch
from
7a676ed
to
44bfa0e
Compare
|
PR is now waiting for a maintainer to run the acceptance tests. This PR will only perform build and linting. Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR |
|
Apologies @alexrocco - would you be able to rebase this on top of master? We had some breaks in the linting tool we use which has just been fixed on master. Thanks! |
The DaemonSet name was set with a lower case s (Daemonset), but the kind in the state is created with upper case (DaemonSet), and this was preventing changes on the .spec.selector to trigger a replace. This issue was also causing the Kubernetes API to fail as this field is immutable, but pulumi was trying to update it.
alexrocco
force-pushed
the
alexrocco/fix-daemonset-diff-name
branch
from
44bfa0e
to
52a7121
Compare
|
PR is now waiting for a maintainer to run the acceptance tests. This PR will only perform build and linting. Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR |
|
/run-acceptance-tests |
|
Please view the PR build - https://github.com/pulumi/pulumi-kubernetes/actions/runs/2104814328 |
Proposed changes
The DaemonSet name was set with a lower case s (Daemonset), but the kind
in the state is created with upper case (DaemonSet), and this was
preventing changes on the .spec.selector to trigger a replacement.
This issue was also causing the Kubernetes API to fail as this field is
immutable, but pulumi was trying to update it.
Related issues (optional)
Related to #1008
Ps. I'm still testing it, but this was the only place where the DaemonSet
was with lower case in the code.
Update: Tested locally and this fixes the issue.