-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes for Check() on updates for helm release #1953
Conversation
Does the PR have any schema changes?Looking good! No breaking changes found. |
1 similar comment
Does the PR have any schema changes?Looking good! No breaking changes found. |
Does the PR have any schema changes?Looking good! No breaking changes found. |
2 similar comments
Does the PR have any schema changes?Looking good! No breaking changes found. |
Does the PR have any schema changes?Looking good! No breaking changes found. |
Does the PR have any schema changes?Looking good! No breaking changes found. |
Does the PR have any schema changes?Looking good! No breaking changes found. |
Proposed changes
This change fixes a bug in helm release support where
Check()
wasn't kicking-in for release resources and the default k8s autonaming was being used. The autonames in previews previously bore no similarity to what was used during the apply (when unknowns are resolved).This change also extends support to deterministic autonames using sequence numbers to all kubernetes and helm release resources while we are at it.
Related issues (optional)
Fixes #1933