Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fill in Attach #1977

Merged
merged 3 commits into from
Apr 25, 2022
Merged

Fill in Attach #1977

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b608432
Fill in Attach
Frassle Apr 24, 2022
96cb593
Add to CHANGELOG
Frassle Apr 24, 2022
fb51f0f
empty not pbempty
Frassle Apr 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,9 @@
## Unreleased
- Fix fetching remote yaml files (https://github.com/pulumi/pulumi-kubernetes/pull/1962)

- Support attach
[#1977](https://github.com/pulumi/pulumi-kubernetes/pull/1977)

## 3.18.2 (April 6, 2022)
- Only add keyring default value when verification is turned on (https://github.com/pulumi/pulumi-kubernetes/pull/1961)
Regression introduced in 3.18.1
Expand Down
9 changes: 7 additions & 2 deletions provider/pkg/provider/provider.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1160,8 +1160,13 @@ func (k *kubeProvider) StreamInvoke(
}

// Attach sends the engine address to an already running plugin.
func (k *kubeProvider) Attach(_ context.Context, _ *pulumirpc.PluginAttach) (*empty.Empty, error) {
return nil, status.Error(codes.Unimplemented, "Attach is not yet implemented")
func (k *kubeProvider) Attach(_ context.Context, req *pulumirpc.PluginAttach) (*empty.Empty, error) {
host, err := provider.NewHostClient(req.GetAddress())
if err != nil {
return nil, err
}
k.host = host
return &empty.Empty{}, nil
}

// Check validates that the given property bag is valid for a resource of the given type and returns
Expand Down