Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Server-Side Apply mode #2029

Merged
merged 7 commits into from
Jun 23, 2022
Merged

Implement Server-Side Apply mode #2029

merged 7 commits into from
Jun 23, 2022

Conversation

lblackstone
Copy link
Member

Proposed changes

Add a mode to the provider that uses Server-Side Apply (SSA) for resource management. See #2011 for additional details on the background and design of this feature.

Related issues (optional)

Fix #2016

@github-actions
Copy link

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

@github-actions github-actions bot added the impact/no-changelog-required This issue doesn't require a CHANGELOG update label Jun 16, 2022
@lblackstone lblackstone force-pushed the lblackstone/ssa-support branch 2 times, most recently from 529856b to 7fd8440 Compare June 16, 2022 23:11
@github-actions
Copy link

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

1 similar comment
@github-actions
Copy link

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

@github-actions
Copy link

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

@github-actions
Copy link

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

@lblackstone lblackstone marked this pull request as ready for review June 21, 2022 22:40
@lblackstone lblackstone removed the impact/no-changelog-required This issue doesn't require a CHANGELOG update label Jun 21, 2022
@github-actions
Copy link

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

@github-actions github-actions bot added the impact/no-changelog-required This issue doesn't require a CHANGELOG update label Jun 21, 2022
@github-actions
Copy link

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

viveklak
viveklak suggested changes Jun 22, 2022
View reviewed changes
Copy link
Contributor

@viveklak viveklak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great! Some minor suggestions and questions but its coming together nicely!

provider/pkg/await/await.go Show resolved Hide resolved
provider/pkg/await/await.go Outdated Show resolved Hide resolved
provider/pkg/await/await.go Show resolved Hide resolved
provider/pkg/await/await.go Outdated Show resolved Hide resolved
provider/pkg/metadata/annotations.go Outdated Show resolved Hide resolved
provider/pkg/provider/provider.go Outdated Show resolved Hide resolved
provider/pkg/provider/provider.go Outdated Show resolved Hide resolved
provider/pkg/provider/provider.go Show resolved Hide resolved
provider/pkg/provider/provider.go Show resolved Hide resolved
provider/pkg/ssa/actions.go Outdated Show resolved Hide resolved
@lblackstone
Implement Server-Side Apply mode
2ca65c0 
Add a mode to the provider that uses Server-Side Apply (SSA) for resource management. See #2011 for additional details on the background and design of this feature.
@lblackstone
Almost working
c12d7f5
@lblackstone
Pull out common code
975ce19
@lblackstone
changelog
6f6aa78
@lblackstone
Fix Create preview logic for SSA
49e2c8e
@lblackstone
Address feedback
7adb8b2
@lblackstone
Update contexts
912ccd0
@github-actions
Copy link

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

@viveklak viveklak removed the impact/no-changelog-required This issue doesn't require a CHANGELOG update label Jun 23, 2022
viveklak
viveklak reviewed Jun 23, 2022
View reviewed changes
CHANGELOG.md
@@ -1,5 +1,7 @@
## Unreleased

- Implement Server-Side Apply mode (https://github.com/pulumi/pulumi-kubernetes/pull/2029)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add some more details on how to enable this. (And mark it preview etc.)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll add that in a followup PR. This isn't really feature-complete yet, so I'm not quite ready to encourage usage.

@lblackstone lblackstone merged commit 3a48081 into master Jun 23, 2022
@pulumi-bot pulumi-bot deleted the lblackstone/ssa-support branch June 23, 2022 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@viveklak viveklak viveklak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Epic: Patch] Add Server-Side Apply logic to the provider
2 participants
@lblackstone @viveklak