Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support deleting resources on unreachable cluster #2037

Merged
merged 1 commit into from
Jun 20, 2022

Conversation

stack72
Copy link
Contributor

@stack72 stack72 commented Jun 20, 2022

Fixes: #2033

Introduces kubernetes:deleteUnresponsive and PULUMI_K8S_DELETE_UNREACHABLE
as ways of being able to specify that you want to delete resources
when a cluster is unreachable

asciicast

@stack72 stack72 requested a review from lblackstone June 20, 2022 17:14
@github-actions
Copy link

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

@github-actions github-actions bot added the impact/no-changelog-required This issue doesn't require a CHANGELOG update label Jun 20, 2022
@github-actions
Copy link

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

@stack72 stack72 removed the impact/no-changelog-required This issue doesn't require a CHANGELOG update label Jun 20, 2022
Copy link
Member

@lblackstone lblackstone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM aside from the message wording 🎉

provider/pkg/gen/schema.go Outdated Show resolved Hide resolved
Fixes: #2033

Introduces `kubernetes:deleteUnreachable` and `PULUMI_K8S_DELETE_UNREACHABLE`
as ways of being able to specify that you want to delete resources
when a cluster is unreachable
@github-actions
Copy link

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

@github-actions github-actions bot added the impact/no-changelog-required This issue doesn't require a CHANGELOG update label Jun 20, 2022
@stack72 stack72 merged commit 95dcf29 into master Jun 20, 2022
@stack72 stack72 deleted the fix-delete-unresponsive branch June 20, 2022 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impact/no-changelog-required This issue doesn't require a CHANGELOG update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Requesting: on error in refresh for unreachable cluster, allow marking as deleted
3 participants