Add Patch resources to all SDKs #2043
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
impact/no-changelog-required
lblackstone
force-pushed
the
lblackstone/patch-resources
branch
2 times, most recently
from
4e2ba41
to
d93c859
Compare
lblackstone
force-pushed
the
lblackstone/patch-resources
branch
from
d93c859
to
24b94a2
Compare
Add Patch resources for all Kubernetes resource types that can be used to patch existing cluster resources rather than creating a new resource under Pulumi management. See #2011 for additional details on the background and design of this feature.
lblackstone
force-pushed
the
lblackstone/patch-resources
branch
from
24b94a2
to
658e30b
Compare
lblackstone
force-pushed
the
lblackstone/patch-resources
branch
from
658e30b
to
4167799
Compare
This comment was marked as outdated.
This comment was marked as outdated.
viveklak
reviewed
Jul 12, 2022
Does the PR have any schema changes?Looking good! No breaking changes found. New resources:
|
viveklak
reviewed
Jul 12, 2022
provider/pkg/gen/_go-templates/apiextensions/customResourcePatch.go
Outdated
Show resolved
Hide resolved
| @@ -1285,6 +1285,71 @@ var apiextentionsCustomResource = pschema.ResourceSpec{ | |||
| }, | |||
| } | |||
|
|
|||
| var apiextentionsCustomResourcePatch = pschema.ResourceSpec{ | |||
There was a problem hiding this comment.
In the interest of avoiding unnecessary duplication, refer to properties etc. from apiextentionsCustomResource instead?
viveklak
reviewed
Jul 12, 2022
viveklak
reviewed
Jul 12, 2022
viveklak
reviewed
Jul 12, 2022
viveklak
reviewed
Jul 12, 2022
viveklak
reviewed
Jul 12, 2022
| @@ -2683,12 +2707,13 @@ func (k *kubeProvider) tryServerSidePatch( | |||
| return nil, nil, false, err | |||
| } | |||
| } | |||
| if err != nil { | |||
| return nil, nil, false, err | |||
| if err.Error() == "name is required" { | |||
There was a problem hiding this comment.
Nit - consider returning a strongly typed error for this instead?
viveklak
approved these changes
Jul 12, 2022
Does the PR have any schema changes?Looking good! No breaking changes found. New resources:
|
Sounds good! I will make another pass through these feedback items once this merges. |
lblackstone
removed
the
impact/no-changelog-required
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Add Patch resources for all Kubernetes resource types that can be used to patch existing cluster resources rather than creating a new resource under Pulumi management. See #2011 for additional details on the background and design of this feature.
Related issues (optional)
Fix #2015