Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Java packages overrides to schema #2055

Merged
merged 1 commit into from Jul 11, 2022
Merged

Add Java packages overrides to schema #2055

merged 1 commit into from Jul 11, 2022

Conversation

pawelprazak
Copy link
Contributor

@pawelprazak pawelprazak commented Jul 1, 2022 •
edited by lblackstone

Proposed changes

Fixes pulumi/pulumi-java#381

Related issues (optional)

Fix pulumi/pulumi-java#381

@github-actions
Copy link

github-actions bot commented Jul 1, 2022

PR is now waiting for a maintainer to run the acceptance tests.
Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR

@pawelprazak pawelprazak mentioned this pull request Jul 1, 2022
Closed
@lblackstone
Copy link
Member

/run-acceptance-tests

@lblackstone lblackstone self-requested a review July 1, 2022 21:16
@pulumi-bot
Copy link
Contributor

Please view the PR build: https://github.com/pulumi/pulumi-kubernetes/actions/runs/2599155190

@stack72
Copy link
Contributor

stack72 commented Jul 5, 2022

@pawelprazak is this a breaking change?

@pawelprazak
Copy link
Contributor Author

@stack72 IIUC it should not break things in other languages, but for Java it is very breaking, it will change package names, and also because e.g. eks provider will stop compile until this is released, and only then the changes can be propagated - that is how I understand this dependency between providers

lblackstone
lblackstone requested changes Jul 7, 2022
View reviewed changes
Copy link
Member

@lblackstone lblackstone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change LGTM, but need to update the changelog

@pawelprazak
Copy link
Contributor Author

thank you @lblackstone what would you like to see in the CHANGELOG?

@lblackstone
Copy link
Member

thank you @lblackstone what would you like to see in the CHANGELOG?

Something like this. Add a note about any breaking change, and then a line linking to the relevant PR. Thanks!

@pawelprazak pawelprazak force-pushed the pprazak/381/add-java-packages-overrides branch from 3be6980 to 24d7d00 Compare July 11, 2022 10:03
@github-actions
Copy link

PR is now waiting for a maintainer to run the acceptance tests.
Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR

@pawelprazak pawelprazak force-pushed the pprazak/381/add-java-packages-overrides branch from 24d7d00 to 52b7f37 Compare July 11, 2022 10:06
@github-actions
Copy link

PR is now waiting for a maintainer to run the acceptance tests.
Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR

@pawelprazak
Copy link
Contributor Author

updated and rebased

pawelprazak added a commit to pawelprazak/templates that referenced this pull request Jul 11, 2022
@pawelprazak
Update kubernetes-java template
3acb889 
- adjusts the kuberentes-java template to work after breaking changes in pulumi/pulumi-kubernetes#2055
@pawelprazak pawelprazak mentioned this pull request Jul 11, 2022
Merged
@lblackstone
Copy link
Member

/run-acceptance-tests

@pulumi-bot
Copy link
Contributor

Please view the PR build: https://github.com/pulumi/pulumi-kubernetes/actions/runs/2650949105

@lblackstone lblackstone merged commit 817b39f into pulumi:master Jul 11, 2022
@pawelprazak
Copy link
Contributor Author

thank you

@pawelprazak pawelprazak deleted the pprazak/381/add-java-packages-overrides branch July 12, 2022 12:35
@t0yv0 t0yv0 mentioned this pull request Jul 12, 2022
Open
14 tasks
@stack72 stack72 mentioned this pull request Jul 19, 2022
Closed
t0yv0 pushed a commit to pulumi/templates that referenced this pull request Aug 8, 2022
@pawelprazak @t0yv0
Update kubernetes-java template
6022b2b 
- adjusts the kuberentes-java template to work after breaking changes in pulumi/pulumi-kubernetes#2055
t0yv0 pushed a commit to pulumi/templates that referenced this pull request Aug 9, 2022
@pawelprazak @t0yv0
Update kubernetes-java template
82d8be8 
- adjusts the kuberentes-java template to work after breaking changes in pulumi/pulumi-kubernetes#2055
t0yv0 added a commit to pulumi/templates that referenced this pull request Sep 14, 2022
@t0yv0 @pawelprazak
Branch tracking pre-release pulumi/pulumi-java changes (#293)
2225070 
* Update kubernetes-java template

- adjusts the kuberentes-java template to work after breaking changes in pulumi/pulumi-kubernetes#2055

* Update templates to use output-versioned invokes

Co-authored-by: Paweł Prażak <pprazak@virtuslab.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lblackstone lblackstone lblackstone approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix generated package and class names for versioned APIs
4 participants
@pawelprazak @lblackstone @pulumi-bot @stack72