Add missing __pulumiType for Helm charts. #2066
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Does the PR have any schema changes?Looking good! No breaking changes found. |
|
I don't see any changes to the Helm support. Do the |
|
@jkodroff did you miss adding some files? I am only seeing go 1.17 changes for go.mod/go.sum here. |
jkodroff
force-pushed
the
jkodroff/fix-crossguard-helm-chart
branch
from
74d797f
to
40598a8
Compare
viveklak
reviewed
Jul 13, 2022
Does the PR have any schema changes?Looking good! No breaking changes found. |
jkodroff
force-pushed
the
jkodroff/fix-crossguard-helm-chart
branch
2 times, most recently
from
900ba85
to
b79a84b
Compare
Does the PR have any schema changes?Looking good! No breaking changes found. |
1 similar comment
Does the PR have any schema changes?Looking good! No breaking changes found. |
jkodroff
force-pushed
the
jkodroff/fix-crossguard-helm-chart
branch
from
b79a84b
to
e3091c8
Compare
Does the PR have any schema changes?Looking good! No breaking changes found. |
jkodroff
force-pushed
the
jkodroff/fix-crossguard-helm-chart
branch
from
e3091c8
to
531068a
Compare
Does the PR have any schema changes?Looking good! No breaking changes found. |
lblackstone
approved these changes
Jul 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2057