Address Patch feedback

CHANGELOG.md

@@ -1,7 +1,7 @@
 ## Unreleased
 
 - Implement Server-Side Apply mode (https://github.com/pulumi/pulumi-kubernetes/pull/2029)
-- Add Patch resources to all SDKs (https://github.com/pulumi/pulumi-kubernetes/pull/2043)
+- Add Patch resources to all SDKs (https://github.com/pulumi/pulumi-kubernetes/pull/2043) (https://github.com/pulumi/pulumi-kubernetes/pull/2068)
 - Add awaiter for service-account-token secret (https://github.com/pulumi/pulumi-kubernetes/pull/2048)
 - Add Java packages overrides to schema (https://github.com/pulumi/pulumi-kubernetes/pull/2055)
 

provider/pkg/gen/schema.go

@@ -300,6 +300,7 @@ func PulumiSchema(swagger map[string]interface{}) pschema.PackageSpec {
 				}
 
 				// Add "Patch" types corresponding to all non "List" resource kinds.
+				// All fields except for name are made optional by leaving off the required schema field.
 				var patchSpec pschema.ObjectTypeSpec
 				if len(patchTok) > 0 {
 					patchSpec = pschema.ObjectTypeSpec{
@@ -315,6 +316,8 @@ func PulumiSchema(swagger map[string]interface{}) pschema.PackageSpec {
 						propNames = append(propNames, p.name)
 					}
 
+					patchSpec.Language["nodejs"] = rawMessage(map[string][]string{"requiredOutputs": propNames})
+
 					// Check if the current type exists in the overlays and overwrite types accordingly.
 					if overlaySpec, hasType := typeOverlays[tok]; hasType {
 						for propName, overlayProp := range overlaySpec.Properties {
@@ -331,6 +334,10 @@ func PulumiSchema(swagger map[string]interface{}) pschema.PackageSpec {
 						}
 					}
 
+					if patchTok == "kubernetes:meta/v1:ObjectMetaPatch" {
+						patchSpec.Required = []string{"name"}
+					}
+
 					pkg.Types[patchTok] = pschema.ComplexTypeSpec{
 						ObjectTypeSpec: patchSpec,
 					}
@@ -378,6 +385,7 @@ func PulumiSchema(swagger map[string]interface{}) pschema.PackageSpec {
 				pkg.Resources[tok] = resourceSpec
 
 				// Add "Patch" resources corresponding to all non "List" resource kinds.
+				// All fields except for metadata are made optional by leaving off the requiredInputs schema field.
 				if len(patchTok) > 0 {
 					patchResourceSpec := pschema.ResourceSpec{
 						ObjectTypeSpec:     patchSpec,
@@ -392,6 +400,8 @@ func PulumiSchema(swagger map[string]interface{}) pschema.PackageSpec {
 						patchResourceSpec.InputProperties[p.name] = genPropertySpec(p, kind.apiVersion, kind.kind+"Patch")
 					}
 
+					patchResourceSpec.RequiredInputs = []string{"metadata"}
+
 					for _, t := range kind.Aliases() {
 						aliasedType := fmt.Sprintf("%sPatch", t)
 						patchResourceSpec.Aliases = append(patchResourceSpec.Aliases, pschema.AliasSpec{Type: &aliasedType})

sdk/dotnet/AdmissionRegistration/V1/MutatingWebhookConfigurationPatch.cs

@@ -118,8 +118,8 @@ public class MutatingWebhookConfigurationPatchArgs : Pulumi.ResourceArgs
         /// <summary>
         /// Standard object metadata; More info: https://git.k8s.io/community/contributors/devel/sig-architecture/api-conventions.md#metadata.
         /// </summary>
-        [Input("metadata")]
-        public Input<Pulumi.Kubernetes.Types.Inputs.Meta.V1.ObjectMetaPatchArgs>? Metadata { get; set; }
+        [Input("metadata", required: true)]
+        public Input<Pulumi.Kubernetes.Types.Inputs.Meta.V1.ObjectMetaPatchArgs> Metadata { get; set; } = null!;
 
         [Input("webhooks")]
         private InputList<Pulumi.Kubernetes.Types.Inputs.AdmissionRegistration.V1.MutatingWebhookPatchArgs>? _webhooks;

sdk/dotnet/AdmissionRegistration/V1/ValidatingWebhookConfigurationPatch.cs

@@ -118,8 +118,8 @@ public class ValidatingWebhookConfigurationPatchArgs : Pulumi.ResourceArgs
         /// <summary>
         /// Standard object metadata; More info: https://git.k8s.io/community/contributors/devel/sig-architecture/api-conventions.md#metadata.
         /// </summary>
-        [Input("metadata")]
-        public Input<Pulumi.Kubernetes.Types.Inputs.Meta.V1.ObjectMetaPatchArgs>? Metadata { get; set; }
+        [Input("metadata", required: true)]
+        public Input<Pulumi.Kubernetes.Types.Inputs.Meta.V1.ObjectMetaPatchArgs> Metadata { get; set; } = null!;
 
         [Input("webhooks")]
         private InputList<Pulumi.Kubernetes.Types.Inputs.AdmissionRegistration.V1.ValidatingWebhookPatchArgs>? _webhooks;

sdk/dotnet/AdmissionRegistration/V1Beta1/MutatingWebhookConfigurationPatch.cs

@@ -118,8 +118,8 @@ public class MutatingWebhookConfigurationPatchArgs : Pulumi.ResourceArgs
         /// <summary>
         /// Standard object metadata; More info: https://git.k8s.io/community/contributors/devel/sig-architecture/api-conventions.md#metadata.
         /// </summary>
-        [Input("metadata")]
-        public Input<Pulumi.Kubernetes.Types.Inputs.Meta.V1.ObjectMetaPatchArgs>? Metadata { get; set; }
+        [Input("metadata", required: true)]
+        public Input<Pulumi.Kubernetes.Types.Inputs.Meta.V1.ObjectMetaPatchArgs> Metadata { get; set; } = null!;
 
         [Input("webhooks")]
         private InputList<Pulumi.Kubernetes.Types.Inputs.AdmissionRegistration.V1Beta1.MutatingWebhookPatchArgs>? _webhooks;

sdk/dotnet/AdmissionRegistration/V1Beta1/ValidatingWebhookConfigurationPatch.cs

@@ -118,8 +118,8 @@ public class ValidatingWebhookConfigurationPatchArgs : Pulumi.ResourceArgs
         /// <summary>
         /// Standard object metadata; More info: https://git.k8s.io/community/contributors/devel/sig-architecture/api-conventions.md#metadata.
         /// </summary>
-        [Input("metadata")]
-        public Input<Pulumi.Kubernetes.Types.Inputs.Meta.V1.ObjectMetaPatchArgs>? Metadata { get; set; }
+        [Input("metadata", required: true)]
+        public Input<Pulumi.Kubernetes.Types.Inputs.Meta.V1.ObjectMetaPatchArgs> Metadata { get; set; } = null!;
 
         [Input("webhooks")]
         private InputList<Pulumi.Kubernetes.Types.Inputs.AdmissionRegistration.V1Beta1.ValidatingWebhookPatchArgs>? _webhooks;

sdk/dotnet/ApiExtensions/V1/CustomResourceDefinitionPatch.cs

@@ -124,8 +124,8 @@ public class CustomResourceDefinitionPatchArgs : Pulumi.ResourceArgs
         /// <summary>
         /// Standard object's metadata More info: https://git.k8s.io/community/contributors/devel/sig-architecture/api-conventions.md#metadata
         /// </summary>
-        [Input("metadata")]
-        public Input<Pulumi.Kubernetes.Types.Inputs.Meta.V1.ObjectMetaPatchArgs>? Metadata { get; set; }
+        [Input("metadata", required: true)]
+        public Input<Pulumi.Kubernetes.Types.Inputs.Meta.V1.ObjectMetaPatchArgs> Metadata { get; set; } = null!;
 
         /// <summary>
         /// spec describes how the user wants the resources to appear

sdk/dotnet/ApiExtensions/V1Beta1/CustomResourceDefinitionPatch.cs

@@ -118,8 +118,8 @@ public class CustomResourceDefinitionPatchArgs : Pulumi.ResourceArgs
         [Input("kind")]
         public Input<string>? Kind { get; set; }
 
-        [Input("metadata")]
-        public Input<Pulumi.Kubernetes.Types.Inputs.Meta.V1.ObjectMetaPatchArgs>? Metadata { get; set; }
+        [Input("metadata", required: true)]
+        public Input<Pulumi.Kubernetes.Types.Inputs.Meta.V1.ObjectMetaPatchArgs> Metadata { get; set; } = null!;
 
         /// <summary>
         /// spec describes how the user wants the resources to appear

sdk/dotnet/ApiRegistration/V1/APIServicePatch.cs

@@ -126,8 +126,8 @@ public class APIServicePatchArgs : Pulumi.ResourceArgs
         /// <summary>
         /// Standard object's metadata. More info: https://git.k8s.io/community/contributors/devel/sig-architecture/api-conventions.md#metadata
         /// </summary>
-        [Input("metadata")]
-        public Input<Pulumi.Kubernetes.Types.Inputs.Meta.V1.ObjectMetaPatchArgs>? Metadata { get; set; }
+        [Input("metadata", required: true)]
+        public Input<Pulumi.Kubernetes.Types.Inputs.Meta.V1.ObjectMetaPatchArgs> Metadata { get; set; } = null!;
 
         /// <summary>
         /// Spec contains information for locating and communicating with a server

sdk/dotnet/ApiRegistration/V1Beta1/APIServicePatch.cs

@@ -120,8 +120,8 @@ public class APIServicePatchArgs : Pulumi.ResourceArgs
         [Input("kind")]
         public Input<string>? Kind { get; set; }
 
-        [Input("metadata")]
-        public Input<Pulumi.Kubernetes.Types.Inputs.Meta.V1.ObjectMetaPatchArgs>? Metadata { get; set; }
+        [Input("metadata", required: true)]
+        public Input<Pulumi.Kubernetes.Types.Inputs.Meta.V1.ObjectMetaPatchArgs> Metadata { get; set; } = null!;
 
         /// <summary>
         /// Spec contains information for locating and communicating with a server

sdk/dotnet/Apps/V1/ControllerRevisionPatch.cs

@@ -131,8 +131,8 @@ public class ControllerRevisionPatchArgs : Pulumi.ResourceArgs
         /// <summary>
         /// Standard object's metadata. More info: https://git.k8s.io/community/contributors/devel/sig-architecture/api-conventions.md#metadata
         /// </summary>
-        [Input("metadata")]
-        public Input<Pulumi.Kubernetes.Types.Inputs.Meta.V1.ObjectMetaPatchArgs>? Metadata { get; set; }
+        [Input("metadata", required: true)]
+        public Input<Pulumi.Kubernetes.Types.Inputs.Meta.V1.ObjectMetaPatchArgs> Metadata { get; set; } = null!;
 
         /// <summary>
         /// Revision indicates the revision of the state represented by Data.

sdk/dotnet/Apps/V1/DaemonSetPatch.cs

@@ -125,8 +125,8 @@ public class DaemonSetPatchArgs : Pulumi.ResourceArgs
         /// <summary>
         /// Standard object's metadata. More info: https://git.k8s.io/community/contributors/devel/sig-architecture/api-conventions.md#metadata
         /// </summary>
-        [Input("metadata")]
-        public Input<Pulumi.Kubernetes.Types.Inputs.Meta.V1.ObjectMetaPatchArgs>? Metadata { get; set; }
+        [Input("metadata", required: true)]
+        public Input<Pulumi.Kubernetes.Types.Inputs.Meta.V1.ObjectMetaPatchArgs> Metadata { get; set; } = null!;
 
         /// <summary>
         /// The desired behavior of this daemon set. More info: https://git.k8s.io/community/contributors/devel/sig-architecture/api-conventions.md#spec-and-status

sdk/dotnet/Apps/V1/DeploymentPatch.cs

@@ -148,8 +148,8 @@ public class DeploymentPatchArgs : Pulumi.ResourceArgs
         /// <summary>
         /// Standard object's metadata. More info: https://git.k8s.io/community/contributors/devel/sig-architecture/api-conventions.md#metadata
         /// </summary>
-        [Input("metadata")]
-        public Input<Pulumi.Kubernetes.Types.Inputs.Meta.V1.ObjectMetaPatchArgs>? Metadata { get; set; }
+        [Input("metadata", required: true)]
+        public Input<Pulumi.Kubernetes.Types.Inputs.Meta.V1.ObjectMetaPatchArgs> Metadata { get; set; } = null!;
 
         /// <summary>
         /// Specification of the desired behavior of the Deployment.

sdk/dotnet/Apps/V1/ReplicaSetPatch.cs

@@ -125,8 +125,8 @@ public class ReplicaSetPatchArgs : Pulumi.ResourceArgs
         /// <summary>
         /// If the Labels of a ReplicaSet are empty, they are defaulted to be the same as the Pod(s) that the ReplicaSet manages. Standard object's metadata. More info: https://git.k8s.io/community/contributors/devel/sig-architecture/api-conventions.md#metadata
         /// </summary>
-        [Input("metadata")]
-        public Input<Pulumi.Kubernetes.Types.Inputs.Meta.V1.ObjectMetaPatchArgs>? Metadata { get; set; }
+        [Input("metadata", required: true)]
+        public Input<Pulumi.Kubernetes.Types.Inputs.Meta.V1.ObjectMetaPatchArgs> Metadata { get; set; } = null!;
 
         /// <summary>
         /// Spec defines the specification of the desired behavior of the ReplicaSet. More info: https://git.k8s.io/community/contributors/devel/sig-architecture/api-conventions.md#spec-and-status

sdk/dotnet/Apps/V1/StatefulSetPatch.cs

@@ -141,8 +141,8 @@ public class StatefulSetPatchArgs : Pulumi.ResourceArgs
         /// <summary>
         /// Standard object's metadata. More info: https://git.k8s.io/community/contributors/devel/sig-architecture/api-conventions.md#metadata
         /// </summary>
-        [Input("metadata")]
-        public Input<Pulumi.Kubernetes.Types.Inputs.Meta.V1.ObjectMetaPatchArgs>? Metadata { get; set; }
+        [Input("metadata", required: true)]
+        public Input<Pulumi.Kubernetes.Types.Inputs.Meta.V1.ObjectMetaPatchArgs> Metadata { get; set; } = null!;
 
         /// <summary>
         /// Spec defines the desired identities of pods in this set.

sdk/dotnet/Apps/V1Beta1/ControllerRevisionPatch.cs

@@ -132,8 +132,8 @@ public class ControllerRevisionPatchArgs : Pulumi.ResourceArgs
         /// <summary>
         /// Standard object's metadata. More info: https://git.k8s.io/community/contributors/devel/sig-architecture/api-conventions.md#metadata
         /// </summary>
-        [Input("metadata")]
-        public Input<Pulumi.Kubernetes.Types.Inputs.Meta.V1.ObjectMetaPatchArgs>? Metadata { get; set; }
+        [Input("metadata", required: true)]
+        public Input<Pulumi.Kubernetes.Types.Inputs.Meta.V1.ObjectMetaPatchArgs> Metadata { get; set; } = null!;
 
         /// <summary>
         /// Revision indicates the revision of the state represented by Data.

sdk/dotnet/Apps/V1Beta1/DeploymentPatch.cs

@@ -149,8 +149,8 @@ public class DeploymentPatchArgs : Pulumi.ResourceArgs
         /// <summary>
         /// Standard object metadata.
         /// </summary>
-        [Input("metadata")]
-        public Input<Pulumi.Kubernetes.Types.Inputs.Meta.V1.ObjectMetaPatchArgs>? Metadata { get; set; }
+        [Input("metadata", required: true)]
+        public Input<Pulumi.Kubernetes.Types.Inputs.Meta.V1.ObjectMetaPatchArgs> Metadata { get; set; } = null!;
 
         /// <summary>
         /// Specification of the desired behavior of the Deployment.

sdk/dotnet/Apps/V1Beta1/StatefulSetPatch.cs

@@ -136,8 +136,8 @@ public class StatefulSetPatchArgs : Pulumi.ResourceArgs
         [Input("kind")]
         public Input<string>? Kind { get; set; }
 
-        [Input("metadata")]
-        public Input<Pulumi.Kubernetes.Types.Inputs.Meta.V1.ObjectMetaPatchArgs>? Metadata { get; set; }
+        [Input("metadata", required: true)]
+        public Input<Pulumi.Kubernetes.Types.Inputs.Meta.V1.ObjectMetaPatchArgs> Metadata { get; set; } = null!;
 
         /// <summary>
         /// Spec defines the desired identities of pods in this set.

sdk/dotnet/Apps/V1Beta2/ControllerRevisionPatch.cs

@@ -132,8 +132,8 @@ public class ControllerRevisionPatchArgs : Pulumi.ResourceArgs
         /// <summary>
         /// Standard object's metadata. More info: https://git.k8s.io/community/contributors/devel/sig-architecture/api-conventions.md#metadata
         /// </summary>
-        [Input("metadata")]
-        public Input<Pulumi.Kubernetes.Types.Inputs.Meta.V1.ObjectMetaPatchArgs>? Metadata { get; set; }
+        [Input("metadata", required: true)]
+        public Input<Pulumi.Kubernetes.Types.Inputs.Meta.V1.ObjectMetaPatchArgs> Metadata { get; set; } = null!;
 
         /// <summary>
         /// Revision indicates the revision of the state represented by Data.

sdk/dotnet/Apps/V1Beta2/DaemonSetPatch.cs

@@ -126,8 +126,8 @@ public class DaemonSetPatchArgs : Pulumi.ResourceArgs
         /// <summary>
         /// Standard object's metadata. More info: https://git.k8s.io/community/contributors/devel/sig-architecture/api-conventions.md#metadata
         /// </summary>
-        [Input("metadata")]
-        public Input<Pulumi.Kubernetes.Types.Inputs.Meta.V1.ObjectMetaPatchArgs>? Metadata { get; set; }
+        [Input("metadata", required: true)]
+        public Input<Pulumi.Kubernetes.Types.Inputs.Meta.V1.ObjectMetaPatchArgs> Metadata { get; set; } = null!;
 
         /// <summary>
         /// The desired behavior of this daemon set. More info: https://git.k8s.io/community/contributors/devel/sig-architecture/api-conventions.md#spec-and-status

sdk/dotnet/Apps/V1Beta2/DeploymentPatch.cs

@@ -149,8 +149,8 @@ public class DeploymentPatchArgs : Pulumi.ResourceArgs
         /// <summary>
         /// Standard object metadata.
         /// </summary>
-        [Input("metadata")]
-        public Input<Pulumi.Kubernetes.Types.Inputs.Meta.V1.ObjectMetaPatchArgs>? Metadata { get; set; }
+        [Input("metadata", required: true)]
+        public Input<Pulumi.Kubernetes.Types.Inputs.Meta.V1.ObjectMetaPatchArgs> Metadata { get; set; } = null!;
 
         /// <summary>
         /// Specification of the desired behavior of the Deployment.

sdk/dotnet/Apps/V1Beta2/ReplicaSetPatch.cs

@@ -126,8 +126,8 @@ public class ReplicaSetPatchArgs : Pulumi.ResourceArgs
         /// <summary>
         /// If the Labels of a ReplicaSet are empty, they are defaulted to be the same as the Pod(s) that the ReplicaSet manages. Standard object's metadata. More info: https://git.k8s.io/community/contributors/devel/sig-architecture/api-conventions.md#metadata
         /// </summary>
-        [Input("metadata")]
-        public Input<Pulumi.Kubernetes.Types.Inputs.Meta.V1.ObjectMetaPatchArgs>? Metadata { get; set; }
+        [Input("metadata", required: true)]
+        public Input<Pulumi.Kubernetes.Types.Inputs.Meta.V1.ObjectMetaPatchArgs> Metadata { get; set; } = null!;
 
         /// <summary>
         /// Spec defines the specification of the desired behavior of the ReplicaSet. More info: https://git.k8s.io/community/contributors/devel/sig-architecture/api-conventions.md#spec-and-status

sdk/dotnet/Apps/V1Beta2/StatefulSetPatch.cs

@@ -136,8 +136,8 @@ public class StatefulSetPatchArgs : Pulumi.ResourceArgs
         [Input("kind")]
         public Input<string>? Kind { get; set; }
 
-        [Input("metadata")]
-        public Input<Pulumi.Kubernetes.Types.Inputs.Meta.V1.ObjectMetaPatchArgs>? Metadata { get; set; }
+        [Input("metadata", required: true)]
+        public Input<Pulumi.Kubernetes.Types.Inputs.Meta.V1.ObjectMetaPatchArgs> Metadata { get; set; } = null!;
 
         /// <summary>
         /// Spec defines the desired identities of pods in this set.

sdk/dotnet/AuditRegistraion/V1Alpha1/AuditSinkPatch.cs

@@ -108,8 +108,8 @@ public class AuditSinkPatchArgs : Pulumi.ResourceArgs
         [Input("kind")]
         public Input<string>? Kind { get; set; }
 
-        [Input("metadata")]
-        public Input<Pulumi.Kubernetes.Types.Inputs.Meta.V1.ObjectMetaPatchArgs>? Metadata { get; set; }
+        [Input("metadata", required: true)]
+        public Input<Pulumi.Kubernetes.Types.Inputs.Meta.V1.ObjectMetaPatchArgs> Metadata { get; set; } = null!;
 
         /// <summary>
         /// Spec defines the audit configuration spec

sdk/dotnet/Authentication/V1/TokenRequestPatch.cs

@@ -120,8 +120,8 @@ public class TokenRequestPatchArgs : Pulumi.ResourceArgs
         /// <summary>
         /// Standard object's metadata. More info: https://git.k8s.io/community/contributors/devel/sig-architecture/api-conventions.md#metadata
         /// </summary>
-        [Input("metadata")]
-        public Input<Pulumi.Kubernetes.Types.Inputs.Meta.V1.ObjectMetaPatchArgs>? Metadata { get; set; }
+        [Input("metadata", required: true)]
+        public Input<Pulumi.Kubernetes.Types.Inputs.Meta.V1.ObjectMetaPatchArgs> Metadata { get; set; } = null!;
 
         /// <summary>
         /// Spec holds information about the request being evaluated

sdk/dotnet/Authentication/V1/TokenReviewPatch.cs

@@ -124,8 +124,8 @@ public class TokenReviewPatchArgs : Pulumi.ResourceArgs
         /// <summary>
         /// Standard object's metadata. More info: https://git.k8s.io/community/contributors/devel/sig-architecture/api-conventions.md#metadata
         /// </summary>
-        [Input("metadata")]
-        public Input<Pulumi.Kubernetes.Types.Inputs.Meta.V1.ObjectMetaPatchArgs>? Metadata { get; set; }
+        [Input("metadata", required: true)]
+        public Input<Pulumi.Kubernetes.Types.Inputs.Meta.V1.ObjectMetaPatchArgs> Metadata { get; set; } = null!;
 
         /// <summary>
         /// Spec holds information about the request being evaluated

sdk/dotnet/Authentication/V1Beta1/TokenReviewPatch.cs

@@ -118,8 +118,8 @@ public class TokenReviewPatchArgs : Pulumi.ResourceArgs
         [Input("kind")]
         public Input<string>? Kind { get; set; }
 
-        [Input("metadata")]
-        public Input<Pulumi.Kubernetes.Types.Inputs.Meta.V1.ObjectMetaPatchArgs>? Metadata { get; set; }
+        [Input("metadata", required: true)]
+        public Input<Pulumi.Kubernetes.Types.Inputs.Meta.V1.ObjectMetaPatchArgs> Metadata { get; set; } = null!;
 
         /// <summary>
         /// Spec holds information about the request being evaluated

sdk/dotnet/Authorization/V1/LocalSubjectAccessReviewPatch.cs

@@ -124,8 +124,8 @@ public class LocalSubjectAccessReviewPatchArgs : Pulumi.ResourceArgs
         /// <summary>
         /// Standard list metadata. More info: https://git.k8s.io/community/contributors/devel/sig-architecture/api-conventions.md#metadata
         /// </summary>
-        [Input("metadata")]
-        public Input<Pulumi.Kubernetes.Types.Inputs.Meta.V1.ObjectMetaPatchArgs>? Metadata { get; set; }
+        [Input("metadata", required: true)]
+        public Input<Pulumi.Kubernetes.Types.Inputs.Meta.V1.ObjectMetaPatchArgs> Metadata { get; set; } = null!;
 
         /// <summary>
         /// Spec holds information about the request being evaluated.  spec.namespace must be equal to the namespace you made the request against.  If empty, it is defaulted.