Update provider and tests to go 1.18 #2073
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Does the PR have any schema changes?Looking good! No breaking changes found. |
jkodroff
force-pushed
the
jkodroff/go1.18
branch
3 times, most recently
from
a4645c4
to
c514e45
Compare
This change fixes an issue building the provider due to a missing reference to an upstream dependency when go 1.16 is used with go mod tidy. We also change appropriate commands in the Makefile to use go 1.17 compatibility mode.
jkodroff
force-pushed
the
jkodroff/go1.18
branch
from
c514e45
to
f9d508f
Compare
Does the PR have any schema changes?Looking good! No breaking changes found. |
1 similar comment
Does the PR have any schema changes?Looking good! No breaking changes found. |
viveklak
approved these changes
Jul 13, 2022
Does the PR have any schema changes?Looking good! No breaking changes found. |
1 similar comment
Does the PR have any schema changes?Looking good! No breaking changes found. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes an issue building the provider due to a missing
reference to an upstream dependency when go 1.16 is used with go mod
tidy. We also change appropriate commands in the Makefile to use go
1.17 compatibility mode.
Proposed changes
Related issues (optional)