Add a descriptive message for an invalid Patch delete #2111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Does the PR have any schema changes?Looking good! No breaking changes found. |
viveklak
reviewed
Jul 29, 2022
| awaitErr = fmt.Errorf( | ||
| "this Patch resource is currently managing a required field, so it can't be deleted "+ | ||
| "directly. Either set the `retainOnDelete` resource option, or transfer ownership of the "+ | ||
| "field before deleting: %s", cause.Field) |
There was a problem hiding this comment.
Did we want to add a link to some tutorial for this once we have one?
There was a problem hiding this comment.
Yeah, I'm planning to update the message once we have some better docs online
viveklak
approved these changes
Jul 29, 2022
Does the PR have any schema changes?Looking good! No breaking changes found. |
lblackstone
force-pushed
the
lblackstone/patch-delete-msg
branch
from
fccd615
to
825c5a5
Compare
Does the PR have any schema changes?Looking good! No breaking changes found. |
Does the PR have any schema changes?Looking good! No breaking changes found. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
With this change, the error message looks like this:
Related issues (optional)
Fix #2107