Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update C# YAML GetResource implementation to compile with .NET v6 #2122

Merged
merged 2 commits into from
Aug 9, 2022
Merged

Update C# YAML GetResource implementation to compile with .NET v6 #2122

merged 2 commits into from
Aug 9, 2022

Conversation

lblackstone
Copy link
Member

@lblackstone lblackstone commented Aug 9, 2022 •
edited
Loading

Proposed changes

The previous implementation failed to compile with the following error:

error CS8078: An expression is too long or complex to compile

when using dotnet v6:

dotnet --version
6.0.302

Related issues (optional)

@github-actions
Copy link

github-actions bot commented Aug 9, 2022

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

mikhailshilkov
mikhailshilkov approved these changes Aug 9, 2022
View reviewed changes
Copy link
Member

@mikhailshilkov mikhailshilkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, that's a fascinating edge case of the compiler. The expression is just 220 lines long! :) LGTM if it compiles and works.

@lblackstone lblackstone marked this pull request as ready for review August 9, 2022 20:20
@lblackstone lblackstone merged commit fd362bc into master Aug 9, 2022
@pulumi-bot pulumi-bot deleted the lblackstone/csharp-yaml branch August 9, 2022 20:22
@github-actions
Copy link

github-actions bot commented Aug 9, 2022

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikhailshilkov mikhailshilkov mikhailshilkov approved these changes

@Zaid-Ajaj Zaid-Ajaj Awaiting requested review from Zaid-Ajaj

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lblackstone @mikhailshilkov