Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to Kubernetes v1.25.0 #2129

Merged
merged 2 commits into from
Aug 23, 2022
Merged

Upgrade to Kubernetes v1.25.0 #2129

merged 2 commits into from
Aug 23, 2022

Conversation

stack72
Copy link
Contributor

@stack72 stack72 commented Aug 9, 2022 •
edited by lblackstone
Loading

No description provided.

@stack72 stack72 changed the title Upgrade to Kubernetes v1.25.0 [WIP] Upgrade to Kubernetes v1.25.0 Aug 9, 2022
@github-actions
Copy link

github-actions bot commented Aug 9, 2022

Does the PR have any schema changes?

Found 12 breaking changes:
Type "kubernetes:batch/v1beta1:CronJobSpec" missing property "timeZone"
Type "kubernetes:discovery.k8s.io/v1beta1:EndpointPatch" missing property "hints"
Type "kubernetes:batch/v1beta1:CronJobStatus" missing property "lastSuccessfulTime"
Type "kubernetes:batch/v1beta1:CronJobStatusPatch" missing property "lastSuccessfulTime"
Type "kubernetes:policy/v1beta1:PodDisruptionBudgetStatusPatch" missing property "conditions"
Type "kubernetes:policy/v1beta1:PodDisruptionBudgetStatus" missing property "conditions"
Type "kubernetes:discovery.k8s.io/v1beta1:Endpoint" missing property "hints"
Type "kubernetes:discovery.k8s.io/v1beta1:EndpointHintsPatch" missing
Type "kubernetes:discovery.k8s.io/v1beta1:ForZone" missing
Type "kubernetes:discovery.k8s.io/v1beta1:ForZonePatch" missing
Type "kubernetes:discovery.k8s.io/v1beta1:EndpointHints" missing
Type "kubernetes:batch/v1beta1:CronJobSpecPatch" missing property "timeZone"

New resources:

  • kubernetes:networking.k8s.io/v1alpha1:ClusterCIDR
  • kubernetes:networking.k8s.io/v1alpha1:ClusterCIDRList
  • kubernetes:networking.k8s.io/v1alpha1:ClusterCIDRPatch

@lblackstone
Copy link
Member

It looks like there are a few breaking changes we'll need to look into. We should have until the final release on August 23 to get this fixed.

@viveklak
Copy link
Contributor

viveklak commented Aug 9, 2022

Yeah some of the changes look a bit fishy. We do have time here.

@stack72
Copy link
Contributor Author

stack72 commented Aug 10, 2022

This is why I wanted to get a WIP open to surface the issues :)

@github-actions
Copy link

Does the PR have any schema changes?

Found 12 breaking changes:
Type "kubernetes:discovery.k8s.io/v1beta1:ForZonePatch" missing
Type "kubernetes:batch/v1beta1:CronJobSpecPatch" missing property "timeZone"
Type "kubernetes:policy/v1beta1:PodDisruptionBudgetStatusPatch" missing property "conditions"
Type "kubernetes:discovery.k8s.io/v1beta1:EndpointPatch" missing property "hints"
Type "kubernetes:batch/v1beta1:CronJobSpec" missing property "timeZone"
Type "kubernetes:discovery.k8s.io/v1beta1:ForZone" missing
Type "kubernetes:policy/v1beta1:PodDisruptionBudgetStatus" missing property "conditions"
Type "kubernetes:discovery.k8s.io/v1beta1:EndpointHintsPatch" missing
Type "kubernetes:batch/v1beta1:CronJobStatusPatch" missing property "lastSuccessfulTime"
Type "kubernetes:batch/v1beta1:CronJobStatus" missing property "lastSuccessfulTime"
Type "kubernetes:discovery.k8s.io/v1beta1:Endpoint" missing property "hints"
Type "kubernetes:discovery.k8s.io/v1beta1:EndpointHints" missing

New resources:

  • kubernetes:networking.k8s.io/v1alpha1:ClusterCIDR
  • kubernetes:networking.k8s.io/v1alpha1:ClusterCIDRList
  • kubernetes:networking.k8s.io/v1alpha1:ClusterCIDRPatch

@lblackstone
Copy link
Member

I took a look at the breaking changes and found the following:

  • EndpointHints" missing - This "beta" resource was removed, so no action needed.
  • ForZone missing - This "beta" resource was removed, so no action needed.
  • missing property "conditions" - This was removed from a "beta" API, so no action needed.
  • missing property "timeZone" - This was an "alpha" feature that was removed, so no action needed.
  • missing property "lastSuccessfulTime" - This was removed from a "beta" API, so no action needed.
  • missing property "hints" - This was removed from a "beta" API, so no action needed.

Since all of these changes affect either alpha or beta APIs, and don't appear to be core features, I don't think we need to do anything special to work around for this release.

@stack72
Copy link
Contributor Author

stack72 commented Aug 22, 2022

This is great news @lblackstone - thanks for looking into this :)

@github-actions
Copy link

Does the PR have any schema changes?

Found 12 breaking changes:
Type "kubernetes:policy/v1beta1:PodDisruptionBudgetStatus" missing property "conditions"
Type "kubernetes:batch/v1beta1:CronJobSpec" missing property "timeZone"
Type "kubernetes:discovery.k8s.io/v1beta1:ForZone" missing
Type "kubernetes:batch/v1beta1:CronJobStatus" missing property "lastSuccessfulTime"
Type "kubernetes:discovery.k8s.io/v1beta1:ForZonePatch" missing
Type "kubernetes:discovery.k8s.io/v1beta1:EndpointPatch" missing property "hints"
Type "kubernetes:discovery.k8s.io/v1beta1:EndpointHints" missing
Type "kubernetes:discovery.k8s.io/v1beta1:Endpoint" missing property "hints"
Type "kubernetes:policy/v1beta1:PodDisruptionBudgetStatusPatch" missing property "conditions"
Type "kubernetes:batch/v1beta1:CronJobStatusPatch" missing property "lastSuccessfulTime"
Type "kubernetes:batch/v1beta1:CronJobSpecPatch" missing property "timeZone"
Type "kubernetes:discovery.k8s.io/v1beta1:EndpointHintsPatch" missing

New resources:

  • kubernetes:networking.k8s.io/v1alpha1:ClusterCIDR
  • kubernetes:networking.k8s.io/v1alpha1:ClusterCIDRList
  • kubernetes:networking.k8s.io/v1alpha1:ClusterCIDRPatch

@lblackstone lblackstone changed the title [WIP] Upgrade to Kubernetes v1.25.0 Upgrade to Kubernetes v1.25.0 Aug 23, 2022
@lblackstone lblackstone enabled auto-merge (squash) August 23, 2022 21:39
@github-actions
Copy link

Does the PR have any schema changes?

Found 12 breaking changes:
Type "kubernetes:batch/v1beta1:CronJobStatusPatch" missing property "lastSuccessfulTime"
Type "kubernetes:policy/v1beta1:PodDisruptionBudgetStatusPatch" missing property "conditions"
Type "kubernetes:batch/v1beta1:CronJobSpecPatch" missing property "timeZone"
Type "kubernetes:discovery.k8s.io/v1beta1:EndpointHintsPatch" missing
Type "kubernetes:discovery.k8s.io/v1beta1:ForZone" missing
Type "kubernetes:discovery.k8s.io/v1beta1:ForZonePatch" missing
Type "kubernetes:batch/v1beta1:CronJobStatus" missing property "lastSuccessfulTime"
Type "kubernetes:batch/v1beta1:CronJobSpec" missing property "timeZone"
Type "kubernetes:discovery.k8s.io/v1beta1:Endpoint" missing property "hints"
Type "kubernetes:discovery.k8s.io/v1beta1:EndpointPatch" missing property "hints"
Type "kubernetes:discovery.k8s.io/v1beta1:EndpointHints" missing
Type "kubernetes:policy/v1beta1:PodDisruptionBudgetStatus" missing property "conditions"

New resources:

  • kubernetes:networking.k8s.io/v1alpha1:ClusterCIDR
  • kubernetes:networking.k8s.io/v1alpha1:ClusterCIDRList
  • kubernetes:networking.k8s.io/v1alpha1:ClusterCIDRPatch

@github-actions
Copy link

Does the PR have any schema changes?

Found 12 breaking changes:
Type "kubernetes:policy/v1beta1:PodDisruptionBudgetStatus" missing property "conditions"
Type "kubernetes:discovery.k8s.io/v1beta1:ForZone" missing
Type "kubernetes:batch/v1beta1:CronJobSpec" missing property "timeZone"
Type "kubernetes:batch/v1beta1:CronJobStatusPatch" missing property "lastSuccessfulTime"
Type "kubernetes:discovery.k8s.io/v1beta1:EndpointHints" missing
Type "kubernetes:discovery.k8s.io/v1beta1:EndpointHintsPatch" missing
Type "kubernetes:discovery.k8s.io/v1beta1:Endpoint" missing property "hints"
Type "kubernetes:batch/v1beta1:CronJobStatus" missing property "lastSuccessfulTime"
Type "kubernetes:batch/v1beta1:CronJobSpecPatch" missing property "timeZone"
Type "kubernetes:discovery.k8s.io/v1beta1:ForZonePatch" missing
Type "kubernetes:discovery.k8s.io/v1beta1:EndpointPatch" missing property "hints"
Type "kubernetes:policy/v1beta1:PodDisruptionBudgetStatusPatch" missing property "conditions"

New resources:

  • kubernetes:networking.k8s.io/v1alpha1:ClusterCIDR
  • kubernetes:networking.k8s.io/v1alpha1:ClusterCIDRList
  • kubernetes:networking.k8s.io/v1alpha1:ClusterCIDRPatch

@lblackstone lblackstone merged commit 1f80382 into master Aug 23, 2022
@pulumi-bot pulumi-bot deleted the stack72/kubernetes-v1.25.0 branch August 23, 2022 22:28
@renovate renovate bot mentioned this pull request Jul 28, 2023
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lblackstone lblackstone lblackstone approved these changes

@viveklak viveklak Awaiting requested review from viveklak

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@stack72 @lblackstone @viveklak