Keep managed-by label in SSA mode if already present #2138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lblackstone
force-pushed
the
lblackstone/managed-by-ssa
branch
from
2b73c9b
to
c7779c9
Compare
Does the PR have any schema changes?Looking good! No breaking changes found. |
1 similar comment
Does the PR have any schema changes?Looking good! No breaking changes found. |
viveklak
approved these changes
Aug 15, 2022
lblackstone
added a commit
that referenced
this pull request
Aug 16, 2022
#2138 attempted to fix the case where a resource was created using CSA, and then updated to use SSA. For this case, the resource should retain the "managed-by" label. However, there was a bug in the conditional logic, so that fix was not effective. This change fixes this logic so that the label is only created for CSA resources, but is retained once present on a resource in both cases.
lblackstone
added a commit
that referenced
this pull request
Aug 16, 2022
#2138 attempted to fix the case where a resource was created using CSA, and then updated to use SSA. For this case, the resource should retain the "managed-by" label. However, there was a bug in the conditional logic, so that fix was not effective. This change fixes this logic so that the label is only created for CSA resources, but is retained once present on a resource in both cases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Related issues (optional)