Load default kubeconfig if not specified in provider #2180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Does the PR have any schema changes?Looking good! No breaking changes found. |
1 similar comment
Does the PR have any schema changes?Looking good! No breaking changes found. |
viveklak
approved these changes
Sep 22, 2022
viveklak
reviewed
Sep 22, 2022
Does the PR have any schema changes?Looking good! No breaking changes found. |
The default kubeconfig behavior was previously inconsistent across SDKs, and required the kubeconfig path to be specified manually in some cases. This change unifies the behavior and will load the ambient kubeconfig if unspecified for a provider.
lblackstone
force-pushed
the
lblackstone/kubeconfig-default
branch
from
cd4dffe
to
d0016c0
Compare
Does the PR have any schema changes?Looking good! No breaking changes found. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
The default kubeconfig behavior was previously inconsistent across SDKs, and required the kubeconfig path to be specified manually in some cases. This change unifies the behavior and will load the ambient kubeconfig if unspecified for a provider.
Related issues (optional)
Fix #2072