Qualify Pulumi.Resource type to stay out of the way of the resource API in K8s v1.26.0
#2237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Does the PR have any schema changes?Looking good! No breaking changes found. |
Does the PR have any schema changes?Looking good! No breaking changes found. |
1 similar comment
Does the PR have any schema changes?Looking good! No breaking changes found. |
lblackstone
approved these changes
Nov 17, 2022
Does the PR have any schema changes?Looking good! No breaking changes found. |
squaremo
force-pushed
the
qualify-pulumi-types
branch
from
2f0101c
to
c4cd904
Compare
Does the PR have any schema changes?Looking good! No breaking changes found. |
The next release of Kubernetes (1.26.0) has an API named `resource`. In the .NET codegen, this will end up being a namespace `Resource`, clashing with the type name `Resource` which is implicitly in scope. To avoid this, give the Pulumi namespace an alias and use that to qualify the `Resource` type. Signed-off-by: Michael Bridgen <mbridgen@pulumi.com>
make build This produces code equivalent to previously, but now the templates alias the Pulumi namespace so the `Resource` type won't clash with any upcoming `Resource` namespace. Signed-off-by: Michael Bridgen <mbridgen@pulumi.com>
Signed-off-by: Michael Bridgen <mbridgen@pulumi.com>
squaremo
force-pushed
the
qualify-pulumi-types
branch
from
c4cd904
to
7669dfb
Compare
Does the PR have any schema changes?Looking good! No breaking changes found. |
|
I'm going to merge this, on the basis that it's passed each of the acceptance test suites in at least one run, without the actual change here making any difference to the chance of success. |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes room for the
resourceAPI in Kubernetes v1.26.0, by qualifying the typeResourcein templated code for .NET. It would otherwise clash with the namespaceResourcegenerated to house the new API types.Fixes #2233.