Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make allowNullValues an InputProperty #2255

Merged
merged 2 commits into from
Dec 7, 2022
Merged

Conversation

cdibble
Copy link
Contributor

@cdibble cdibble commented Dec 6, 2022

Proposed changes

  • adds allowNullValues to the resource schema InputProperties
  • rebuilds SDKs to expose the argument so that it can be set with the SDKs

Related issues (optional)

Completes missing piece from #2220 which added this in the Properties but did not allow one to set the value in the SDKs. The objective is to be able to pass empty arrays through to helm deployments when desired.

…lds SDKs to expose the argument so that it can be set with the SDKs
@github-actions
Copy link

github-actions bot commented Dec 6, 2022

PR is now waiting for a maintainer to run the acceptance tests.
Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR

@cdibble
Copy link
Contributor Author

cdibble commented Dec 6, 2022

@lblackstone LMK if this does the trick :)

@github-actions
Copy link

github-actions bot commented Dec 6, 2022

PR is now waiting for a maintainer to run the acceptance tests.
Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR

@lblackstone
Copy link
Member

/run-acceptance-tests

@pulumi-bot
Copy link
Contributor

@lblackstone lblackstone merged commit 8a8d523 into pulumi:master Dec 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants